Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: native_client_sdk/src/build_tools/manifest_util.py

Issue 10868089: add PRESUBMIT for native_client_sdk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/manifest_util.py
diff --git a/native_client_sdk/src/build_tools/manifest_util.py b/native_client_sdk/src/build_tools/manifest_util.py
index 6b6acca904ee5eb549264d68ed7fd2e81968d3dc..57cab4f92c2cb72ec44693dc964132b74e7b2501 100644
--- a/native_client_sdk/src/build_tools/manifest_util.py
+++ b/native_client_sdk/src/build_tools/manifest_util.py
@@ -47,9 +47,9 @@ def GetHostOS():
}[sys.platform]
-def DictToJSON(dict):
+def DictToJSON(pydict):
"""Convert a dict to a JSON-formatted string."""
- pretty_string = json.dumps(dict, sort_keys=False, indent=2)
+ pretty_string = json.dumps(pydict, sort_keys=False, indent=2)
# json.dumps sometimes returns trailing whitespace and does not put
# a newline at the end. This code fixes these problems.
pretty_lines = pretty_string.split('\n')
@@ -108,13 +108,13 @@ class Archive(dict):
""" Create a new archive for the given host-os name. """
self['host_os'] = host_os_name
- def CopyFrom(self, dict):
+ def CopyFrom(self, src):
"""Update the content of the archive by copying values from the given
dictionary.
Args:
- dict: The dictionary whose values must be copied to the archive."""
- for key, value in dict.items():
+ src: The dictionary whose values must be copied to the archive."""
+ for key, value in src.items():
self[key] = value
def Validate(self):
« no previous file with comments | « native_client_sdk/src/build_tools/make_rules.py ('k') | native_client_sdk/src/build_tools/nacl-mono-buildbot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698