add PRESUBMIT for native_client_sdk.

native_client_sdk/src/build_tools/update_nacl_manifest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script that reads omahaproxy and gsutil to determine version of SDK to put
 in manifest.
 """
 
 import buildbot_common
@@ skipping 14 matching lines @@
 
 
 MANIFEST_BASENAME = 'naclsdk_manifest2.json'
 SCRIPT_DIR = os.path.dirname(__file__)
 REPO_MANIFEST = os.path.join(SCRIPT_DIR, 'json', MANIFEST_BASENAME)
 GS_BUCKET_PATH = 'gs://nativeclient-mirror/nacl/nacl_sdk/'
 GS_SDK_MANIFEST = GS_BUCKET_PATH + MANIFEST_BASENAME
 GS_MANIFEST_BACKUP_DIR = GS_BUCKET_PATH + 'manifest_backups/'
 
 CANARY_BUNDLE_NAME = 'pepper_canary'
-CANARY='canary'
+CANARY = 'canary'
 
 
 def SplitVersion(version_string):
   """Split a version string (e.g. "18.0.1025.163") into its components.
 
   Note that this function doesn't handle versions in the form "trunk.###".
   """
   return tuple(map(int, version_string.split('.')))
 
 
@@ skipping 325 matching lines @@
 
     Args:
       with_platform: The name of the platform to filter for.
     Returns:
       A generator that yields a tuple (channel, version) for each version that
       matches the platform and uses the canary channel. The version returned is
       a tuple as returned from SplitVersion.
     """
     for platform, channel, version, _ in self.history:
       version = SplitVersion(version)
-      if with_platform == platform and channel==CANARY:
+      if with_platform == platform and channel == CANARY:
         yield channel, version
 
 
   def _FindNextSharedVersion(self, platforms, generator_func):
     """Yields versions of Chrome that exist on all given platforms, in order of
        newest to oldest.
 
     Versions are compared in reverse order of release. That is, the most
     recently updated version will be tested first.
 
     Args:
       platforms: A sequence of platforms to filter for. Any other platforms will
           be ignored.
     Returns:
       A generator that yields a tuple (version, channel) for each version that
       matches all platforms and the major version. The version returned is a
       string (e.g. "18.0.1025.164").
     """
     platform_generators = []
     for platform in platforms:
       platform_generators.append(generator_func(platform))
 
     shared_version = None
     platform_versions = [(tuple(), '')] * len(platforms)
     while True:
       try:
         for i, platform_gen in enumerate(platform_generators):
           if platform_versions[i][1] != shared_version:
-              platform_versions[i] = platform_gen.next()
+            platform_versions[i] = platform_gen.next()
       except StopIteration:
         return
 
       shared_version = min(v for c, v in platform_versions)
 
       if all(v == shared_version for c, v in platform_versions):
         # grab the channel from an arbitrary platform
         first_platform = platform_versions[0]
         channel = first_platform[0]
         yield JoinVersion(shared_version), channel
 
         # force increment to next version for all platforms
         shared_version = None
 
   def _GetAvailableNaClSDKArchivesFor(self, version_string):
     """Downloads a list of all available archives for a given version.
 
     Args:
       version_string: The version to find archives for. (e.g. "18.0.1025.164")
     Returns:
       A list of strings, each of which is a platform-specific archive URL. (e.g.
       "gs://nativeclient_mirror/nacl/nacl_sdk/18.0.1025.164/"
       "naclsdk_linux.tar.bz2").
 
       All returned URLs will use the gs:// schema."""
     files = self.delegate.GsUtil_ls(GS_BUCKET_PATH + version_string)
 
     assert all(file.startswith('gs://') for file in files)
 
-    archives = [file for file in files if not file.endswith('.json')]
-    manifests = [file for file in files if file.endswith('.json')]
+    archives = [f for f in files if not f.endswith('.json')]
+    manifests = [f for f in files if f.endswith('.json')]
 
     # don't include any archives that don't have an associated manifest.
     return filter(lambda a: a + '.json' in manifests, archives)
 
 
 class Updater(object):
   def __init__(self, delegate):
     self.delegate = delegate
     self.versions_to_update = []
 
@@ skipping 156 matching lines @@
     sys.stderr.write('warning: Disabling email, one of --mailto or --mailfrom '
         'was missing.\n')
 
   if options.mailfrom and options.mailto:
     # Capture stderr so it can be emailed, if necessary.
     sys.stderr = CapturedFile(sys.stderr)
 
   try:
     delegate = RealDelegate(dryrun=options.dryrun, gsutil=options.gsutil)
     Run(delegate, ('mac', 'win', 'linux'))
-  except Exception, e:
+  except Exception:
     if options.mailfrom and options.mailto:
       traceback.print_exc()
       scriptname = os.path.basename(sys.argv[0])
       subject = '[%s] Failed to update manifest' % (scriptname,)
       text = '%s failed.\n\nSTDERR:\n%s\n' % (scriptname, sys.stderr.getvalue())
       SendMail(options.mailfrom, options.mailto, subject, text)
       sys.exit(1)
     else:
       raise
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))