Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: native_client_sdk/PRESUBMIT.py

Issue 10868089: add PRESUBMIT for native_client_sdk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/build_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/PRESUBMIT.py
diff --git a/native_client_sdk/PRESUBMIT.py b/native_client_sdk/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..1b711b9d0bb7ebf08bb958a73d696173ccd5d2bc
--- /dev/null
+++ b/native_client_sdk/PRESUBMIT.py
@@ -0,0 +1,46 @@
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Top-level presubmit script for isolate.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
+details on the presubmit API built into gcl.
+"""
+
+
+def CommonChecks(input_api, output_api):
+ output = []
+ disabled_warnings = [
+ 'R0401', # Cyclic import
+ 'W0613', # Unused argument
+ 'E1103', # subprocess.communicate() generates these :(
+ ]
+ black_list = [r'src/site_scons/.*',
+ r'.*/decode_dump.py',
+ r'src/build_tools/build_sdk.py',
+ r'src/build_tools/buildbot_common.py',
+ r'src/build_tools/buildbot_run.py',
+ r'src/build_tools/build_utils.py',
+ r'src/build_tools/build_updater.py',
+ r'src/build_tools/manifest_util.py',
+ r'src/build_tools/nacl*',
+ r'src/build_tools/generate_make.py',
+ r'src/build_tools/sdk_tools/sdk_update_main.py',
+ r'src/build_tools/sdk_tools/sdk_update.py',
+ r'src/project_templates',
+ r'.*/update_manifest.py',
+ r'.*/update_nacl_manifest.py',
+ r'src/build_tools/tests/.*']
+ canned = input_api.canned_checks
+ output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,
+ disabled_warnings=disabled_warnings))
+ return output
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ return CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ return CommonChecks(input_api, output_api)
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/build_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698