Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: native_client_sdk/src/tools/zip_test.py

Issue 10868089: add PRESUBMIT for native_client_sdk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/tools/oshelpers.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tools/zip_test.py
diff --git a/native_client_sdk/src/tools/zip_test.py b/native_client_sdk/src/tools/zip_test.py
index 76dffba01c10482ebe6a417fcc277d7939bfb634..f3c7dd2d4688f63a10695542d3ddbc3388e721fd 100755
--- a/native_client_sdk/src/tools/zip_test.py
+++ b/native_client_sdk/src/tools/zip_test.py
@@ -95,8 +95,8 @@ class TestZip(unittest.TestCase):
self.assertEqual(self.zipfile.namelist()[0], file1)
def testAddFilesWithGlob(self):
- file1 = self.MakeFile('file1', 1024)
- file2 = self.MakeFile('file2', 3354)
+ self.MakeFile('file1', 1024)
+ self.MakeFile('file2', 3354)
self.RunZip([self.zipname, 'file*'])
self.OpenZipFile()
self.assertEqual(len(self.zipfile.namelist()), 2)
@@ -155,7 +155,7 @@ class TestZip(unittest.TestCase):
os.mkdir(self.GetTempPath('dir1'))
file1 = self.MakeFile(os.path.join('dir1', 'file1'), 256)
os.mkdir(self.GetTempPath(os.path.join('dir1', 'dir2')))
- file2 = self.MakeFile(os.path.join('dir1', 'dir2', 'file2'), 1234)
+ self.MakeFile(os.path.join('dir1', 'dir2', 'file2'), 1234)
self.RunZip([self.zipname, '-r', 'dir1'])
self.OpenZipFile()
self.assertEqual(len(self.zipfile.namelist()), 4)
@@ -189,5 +189,5 @@ def main():
return int(not result.wasSuccessful())
-if __name__=='__main__':
+if __name__ == '__main__':
sys.exit(main())
« no previous file with comments | « native_client_sdk/src/tools/oshelpers.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698