Issue 10854180: Pass const ref instead of pointer for FromDocumentEntry()

Issue 10854180: Pass const ref instead of pointer for FromDocumentEntry() (Closed)

Created:
8 years, 4 months ago by kochi

Modified:
8 years, 4 months ago

Reviewers:
achuithb, hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass const ref instead of pointer for FromDocumentEntry() BUG=none TEST=pass all existing tests, manually run file browser Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151858

Patch Set 2 : fix for comments. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -40 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_directory_service.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_directory_service.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		5 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.cc	View		4 chunks	+23 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_wapi_feed_processor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

https://chromiumcodereview.appspot.com/10854180/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.cc File chrome/browser/chromeos/gdata/gdata_directory_service.cc (right): https://chromiumcodereview.appspot.com/10854180/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.cc#newcode207 chrome/browser/chromeos/gdata/gdata_directory_service.cc:207: DCHECK(&doc); No need to null-check references. https://chromiumcodereview.appspot.com/10854180/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc File chrome/browser/chromeos/gdata/gdata_file_system.cc ...

8 years, 4 months ago (2012-08-16 06:22:54 UTC) #2

kochi

Thanks for the review! https://chromiumcodereview.appspot.com/10854180/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.cc File chrome/browser/chromeos/gdata/gdata_directory_service.cc (right): https://chromiumcodereview.appspot.com/10854180/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.cc#newcode207 chrome/browser/chromeos/gdata/gdata_directory_service.cc:207: DCHECK(&doc); On 2012/08/16 06:22:54, hashimoto ...

8 years, 4 months ago (2012-08-16 06:41:34 UTC) #3

lgtm

Expand Messages | Collapse Messages