Pass const ref instead of pointer for FromDocumentEntry()

chrome/browser/chromeos/gdata/gdata_directory_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_directory_service.h"
 
 #include <leveldb/db.h>
 
 #include "base/message_loop_proxy.h"
 #include "base/string_number_conversions.h"
@@ skipping 185 matching lines @@
 
 GDataDirectoryService::~GDataDirectoryService() {
   ClearRoot();
 
   // Ensure db is closed on the blocking pool.
   if (blocking_task_runner_ && directory_service_db_.get())
     blocking_task_runner_->DeleteSoon(FROM_HERE,
                                       directory_service_db_.release());
 }
 
-GDataEntry* GDataDirectoryService::FromDocumentEntry(DocumentEntry* doc) {
-  DCHECK(doc);
+GDataEntry* GDataDirectoryService::FromDocumentEntry(const DocumentEntry& doc) {
+  DCHECK(&doc);

[hashimoto, 2012/08/16 06:22:54]

No need to null-check references.

[kochi, 2012/08/16 06:41:34]

Done.

   GDataEntry* entry = NULL;
-  if (doc->is_folder())
+  if (doc.is_folder())
     entry = CreateGDataDirectory();
-  else if (doc->is_hosted_document() || doc->is_file())
+  else if (doc.is_hosted_document() || doc.is_file())
     entry = CreateGDataFile();
 
   if (entry)
     entry->InitFromDocumentEntry(doc);
   return entry;
 }
 
 GDataFile* GDataDirectoryService::CreateGDataFile() {
   return new GDataFile(this);
 }
@@ skipping 532 matching lines @@
   DCHECK(result.get());
 
   result->second.path = second_path;
   result->second.error = error;
   result->second.proto = entry_proto.Pass();
 
   callback.Run(result.Pass());
 }
 
 }  // namespace gdata