Pass const ref instead of pointer for FromDocumentEntry()

chrome/browser/chromeos/gdata/gdata_file_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_file_system.h"
 
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 1802 matching lines @@
                                          const GetFileFromCacheParams& params,
                                          GDataErrorCode status,
                                          scoped_ptr<base::Value> data) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   GDataFileError error = util::GDataToGDataFileError(status);
 
   scoped_ptr<GDataEntry> fresh_entry;
   if (error == GDATA_FILE_OK) {
     scoped_ptr<DocumentEntry> doc_entry(DocumentEntry::ExtractAndParse(*data));
-    if (doc_entry.get()) {
-      fresh_entry.reset(directory_service_->FromDocumentEntry(doc_entry.get()));
-    }
+    if (doc_entry.get())
+      fresh_entry.reset(directory_service_->FromDocumentEntry(*doc_entry));

[hashimoto, 2012/08/16 06:22:54]

GDataDirecotryService::FromDocumentEntry's behavior is not obvious from its name
and comment. (Returning GDataEntry, not GDataDirectoryService.  Returning NULL
when the entry is neither a folder, a hosted document nor a file.)
Though this is not your fault, could you fix this in this change or another
change?

[kochi, 2012/08/16 06:41:34]

Filed http://crbug.com/143105.

     if (!fresh_entry.get() || !fresh_entry->AsGDataFile()) {
       LOG(ERROR) << "Got invalid entry from server for " << params.resource_id;
       error = GDATA_FILE_ERROR_FAILED;
     }
   }
 
   if (error != GDATA_FILE_OK) {
     if (!params.get_file_callback.is_null()) {
       params.get_file_callback.Run(error,
                                    cache_file_path,
@@ skipping 543 matching lines @@
     scoped_ptr<std::vector<SearchResultInfo> > result_vec(results);
     if (!callback.is_null())
       callback.Run(error, next_feed, result_vec.Pass());
     return;
   }
 
   // Go through all entires generated by the feed and add them to the search
   // result directory.
   for (size_t i = 0; i < feed->entries().size(); ++i) {
     DocumentEntry* doc = const_cast<DocumentEntry*>(feed->entries()[i]);
-    scoped_ptr<GDataEntry> entry(directory_service_->FromDocumentEntry(doc));
+    scoped_ptr<GDataEntry> entry(directory_service_->FromDocumentEntry(*doc));
 
     if (!entry.get())
       continue;
 
     DCHECK_EQ(doc->resource_id(), entry->resource_id());
     DCHECK(!entry->is_deleted());
 
     std::string entry_resource_id = entry->resource_id();
 
     // This will do nothing if the entry is not already present in file system.
@@ skipping 115 matching lines @@
     callback.Run(error);
     return;
   }
 
   scoped_ptr<DocumentEntry> doc_entry(DocumentEntry::ExtractAndParse(*data));
   if (!doc_entry.get()) {
     callback.Run(GDATA_FILE_ERROR_FAILED);
     return;
   }
 
-  GDataEntry* entry = directory_service_->FromDocumentEntry(doc_entry.get());
+  GDataEntry* entry = directory_service_->FromDocumentEntry(*doc_entry);
   if (!entry) {
     callback.Run(GDATA_FILE_ERROR_FAILED);
     return;
   }
 
   // |entry| was added in the root directory on the server, so we should
   // first add it to |root_| to mirror the state and then move it to the
   // destination directory by MoveEntryFromRootDirectory().
   directory_service_->AddEntryToDirectory(
       directory_service_->root(),
@@ skipping 342 matching lines @@
     return GDATA_FILE_ERROR_FAILED;
 
   // Check if parent is a directory since in theory since this is a callback
   // something could in the meantime have nuked the parent dir and created a
   // file with the exact same name.
   GDataDirectory* parent_dir = entry->AsGDataDirectory();
   if (!parent_dir)
     return GDATA_FILE_ERROR_FAILED;
 
   GDataEntry* new_entry =
-      directory_service_->FromDocumentEntry(doc_entry.get());
+      directory_service_->FromDocumentEntry(*doc_entry);
   if (!new_entry)
     return GDATA_FILE_ERROR_FAILED;
 
   directory_service_->AddEntryToDirectory(
       parent_dir,
       new_entry,
       base::Bind(&GDataFileSystem::NotifyAndRunFileMoveCallback,
                  ui_weak_ptr_,
                  FileMoveCallback()));
   return GDATA_FILE_OK;
@@ skipping 104 matching lines @@
   GDataEntry* dir_entry = directory_service_->FindEntryByPathSync(
       virtual_dir_path);
   if (!dir_entry)
     return;
 
   GDataDirectory* parent_dir  = dir_entry->AsGDataDirectory();
   if (!parent_dir)
     return;
 
   scoped_ptr<GDataEntry> new_entry(
-      directory_service_->FromDocumentEntry(entry.get()));
+      directory_service_->FromDocumentEntry(*entry));
   if (!new_entry.get())
     return;
 
   const std::string& resource_id = new_entry->resource_id();
   AddUploadedFileParams* params =
       new AddUploadedFileParams(upload_mode,
                                 parent_dir,
                                 new_entry.Pass(),
                                 file_content_path,
                                 cache_operation,
@@ skipping 432 matching lines @@
     return;
   }
 
   PlatformFileInfoProto entry_file_info;
   GDataEntry::ConvertPlatformFileInfoToProto(*file_info, &entry_file_info);
   *entry_proto->mutable_file_info() = entry_file_info;
   callback.Run(GDATA_FILE_OK, entry_proto.Pass());
 }
 
 }  // namespace gdata