Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/browser/chromeos/gdata/gdata_directory_service.h

Issue 10854180: Pass const ref instead of pointer for FromDocumentEntry() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_directory_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DIRECTORY_SERVICE_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DIRECTORY_SERVICE_H_
6 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DIRECTORY_SERVICE_H_ 6 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DIRECTORY_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // Largest change timestamp that was the source of content for the current 139 // Largest change timestamp that was the source of content for the current
140 // state of the root directory. 140 // state of the root directory.
141 const int64 largest_changestamp() const { return largest_changestamp_; } 141 const int64 largest_changestamp() const { return largest_changestamp_; }
142 void set_largest_changestamp(int64 value) { largest_changestamp_ = value; } 142 void set_largest_changestamp(int64 value) { largest_changestamp_ = value; }
143 143
144 // The root directory content origin. 144 // The root directory content origin.
145 const ContentOrigin origin() const { return origin_; } 145 const ContentOrigin origin() const { return origin_; }
146 void set_origin(ContentOrigin value) { origin_ = value; } 146 void set_origin(ContentOrigin value) { origin_ = value; }
147 147
148 // Creates a GDataEntry from a DocumentEntry. 148 // Creates a GDataEntry from a DocumentEntry.
149 GDataEntry* FromDocumentEntry(DocumentEntry* doc); 149 GDataEntry* FromDocumentEntry(const DocumentEntry& doc);
150 150
151 // Creates a GDataFile instance. 151 // Creates a GDataFile instance.
152 GDataFile* CreateGDataFile(); 152 GDataFile* CreateGDataFile();
153 153
154 // Creates a GDataDirectory instance. 154 // Creates a GDataDirectory instance.
155 GDataDirectory* CreateGDataDirectory(); 155 GDataDirectory* CreateGDataDirectory();
156 156
157 // Sets root directory resource id and initialize the root entry. 157 // Sets root directory resource id and initialize the root entry.
158 void InitializeRootEntry(const std::string& root_id); 158 void InitializeRootEntry(const std::string& root_id);
159 159
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 // This should remain the last member so it'll be destroyed first and 305 // This should remain the last member so it'll be destroyed first and
306 // invalidate its weak pointers before other members are destroyed. 306 // invalidate its weak pointers before other members are destroyed.
307 base::WeakPtrFactory<GDataDirectoryService> weak_ptr_factory_; 307 base::WeakPtrFactory<GDataDirectoryService> weak_ptr_factory_;
308 308
309 DISALLOW_COPY_AND_ASSIGN(GDataDirectoryService); 309 DISALLOW_COPY_AND_ASSIGN(GDataDirectoryService);
310 }; 310 };
311 311
312 } // namespace gdata 312 } // namespace gdata
313 313
314 #endif // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DIRECTORY_SERVICE_H_ 314 #endif // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DIRECTORY_SERVICE_H_
315
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_directory_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698