Pass const ref instead of pointer for FromDocumentEntry()

chrome/browser/chromeos/gdata/gdata_files.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_files.h"
 
 #include "base/platform_file.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 28 matching lines @@
 }
 
 GDataFile* GDataEntry::AsGDataFile() {
   return NULL;
 }
 
 GDataDirectory* GDataEntry::AsGDataDirectory() {
   return NULL;
 }
 
-void GDataEntry::InitFromDocumentEntry(DocumentEntry* doc) {
+void GDataEntry::InitFromDocumentEntry(const DocumentEntry& doc) {
   // For regular files, the 'filename' and 'title' attribute in the metadata
   // may be different (e.g. due to rename). To be consistent with the web
   // interface and other client to use the 'title' attribute, instead of
   // 'filename', as the file name in the local snapshot.
-  title_ = UTF16ToUTF8(doc->title());
+  title_ = UTF16ToUTF8(doc.title());
   // SetBaseNameFromTitle() must be called after |title_| is set.
   SetBaseNameFromTitle();
 
-  file_info_.last_modified = doc->updated_time();
-  file_info_.last_accessed = doc->updated_time();
-  file_info_.creation_time = doc->published_time();
+  file_info_.last_modified = doc.updated_time();
+  file_info_.last_accessed = doc.updated_time();
+  file_info_.creation_time = doc.published_time();
 
-  resource_id_ = doc->resource_id();
-  content_url_ = doc->content_url();
-  deleted_ = doc->deleted();
+  resource_id_ = doc.resource_id();
+  content_url_ = doc.content_url();
+  deleted_ = doc.deleted();
 
-  const Link* edit_link = doc->GetLinkByType(Link::EDIT);
+  const Link* edit_link = doc.GetLinkByType(Link::EDIT);
   if (edit_link)
     edit_url_ = edit_link->href();
 
-  const Link* parent_link = doc->GetLinkByType(Link::PARENT);
+  const Link* parent_link = doc.GetLinkByType(Link::PARENT);
   if (parent_link)
     parent_resource_id_ = ExtractResourceId(parent_link->href());
 }
 
 const GDataFile* GDataEntry::AsGDataFileConst() const {
   // cast away const and call the non-const version. This is safe.
   return const_cast<GDataEntry*>(this)->AsGDataFile();
 }
 
 const GDataDirectory* GDataEntry::AsGDataDirectoryConst() const {
@@ skipping 51 matching lines @@
 }
 
 void GDataFile::SetBaseNameFromTitle() {
   if (is_hosted_document_) {
     base_name_ = EscapeUtf8FileName(title_ + document_extension_);
   } else {
     GDataEntry::SetBaseNameFromTitle();
   }
 }
 
-void GDataFile::InitFromDocumentEntry(DocumentEntry* doc) {
+void GDataFile::InitFromDocumentEntry(const DocumentEntry& doc) {
   GDataEntry::InitFromDocumentEntry(doc);
 
   // Check if this entry is a true file, or...
-  if (doc->is_file()) {
-    file_info_.size = doc->file_size();
-    file_md5_ = doc->file_md5();
+  if (doc.is_file()) {
+    file_info_.size = doc.file_size();
+    file_md5_ = doc.file_md5();
 
     // The resumable-edit-media link should only be present for regular
     // files as hosted documents are not uploadable.
-    const Link* upload_link = doc->GetLinkByType(Link::RESUMABLE_EDIT_MEDIA);
+    const Link* upload_link = doc.GetLinkByType(Link::RESUMABLE_EDIT_MEDIA);
     if (upload_link)
       upload_url_ = upload_link->href();
   } else {
     // ... a hosted document.
     // Attach .g<something> extension to hosted documents so we can special
     // case their handling in UI.
     // TODO(zelidrag): Figure out better way how to pass entry info like kind
     // to UI through the File API stack.
-    document_extension_ = doc->GetHostedDocumentExtension();
+    document_extension_ = doc.GetHostedDocumentExtension();
     // We don't know the size of hosted docs and it does not matter since
     // is has no effect on the quota.
     file_info_.size = 0;
   }
-  kind_ = doc->kind();
-  content_mime_type_ = doc->content_mime_type();
-  is_hosted_document_ = doc->is_hosted_document();
+  kind_ = doc.kind();
+  content_mime_type_ = doc.content_mime_type();
+  is_hosted_document_ = doc.is_hosted_document();
   // SetBaseNameFromTitle() must be called after |title_|,
   // |is_hosted_document_| and |document_extension_| are set.
   SetBaseNameFromTitle();
 
-  const Link* thumbnail_link = doc->GetLinkByType(Link::THUMBNAIL);
+  const Link* thumbnail_link = doc.GetLinkByType(Link::THUMBNAIL);
   if (thumbnail_link)
     thumbnail_url_ = thumbnail_link->href();
 
-  const Link* alternate_link = doc->GetLinkByType(Link::ALTERNATE);
+  const Link* alternate_link = doc.GetLinkByType(Link::ALTERNATE);
   if (alternate_link)
     alternate_url_ = alternate_link->href();
 }
 
 // GDataDirectory class implementation.
 
 GDataDirectory::GDataDirectory(GDataDirectoryService* directory_service)
     : GDataEntry(directory_service) {
   file_info_.is_directory = true;
 }
 
 GDataDirectory::~GDataDirectory() {
   RemoveChildren();
 }
 
 GDataDirectory* GDataDirectory::AsGDataDirectory() {
   return this;
 }
 
-void GDataDirectory::InitFromDocumentEntry(DocumentEntry* doc) {
+void GDataDirectory::InitFromDocumentEntry(const DocumentEntry& doc) {
   GDataEntry::InitFromDocumentEntry(doc);
 
-  const Link* upload_link = doc->GetLinkByType(Link::RESUMABLE_CREATE_MEDIA);
+  const Link* upload_link = doc.GetLinkByType(Link::RESUMABLE_CREATE_MEDIA);
   if (upload_link)
     upload_url_ = upload_link->href();
 }
 
 void GDataDirectory::AddEntry(GDataEntry* entry) {
   DCHECK(!entry->parent());
 
   // The entry name may have been changed due to prior name de-duplication.
   // We need to first restore the file name based on the title before going
   // through name de-duplication again when it is added to another directory.
@@ skipping 316 matching lines @@
     DCHECK(ok);
   } else if (dir) {
     GDataDirectoryProto dir_proto;
     dir->ToProto(&dir_proto);
     const bool ok = dir_proto.SerializeToString(serialized_proto);
     DCHECK(ok);
   }
 }
 
 }  // namespace gdata