Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/chromeos/gdata/gdata_files.h

Issue 10854180: Pass const ref instead of pointer for FromDocumentEntry() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | chrome/browser/chromeos/gdata/gdata_files.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_files.h
diff --git a/chrome/browser/chromeos/gdata/gdata_files.h b/chrome/browser/chromeos/gdata/gdata_files.h
index dd7e7267c5d1280161265abf2af16a451eb871f8..75bca00740a5b1052fab5da2d421b2a88ad6b667 100644
--- a/chrome/browser/chromeos/gdata/gdata_files.h
+++ b/chrome/browser/chromeos/gdata/gdata_files.h
@@ -41,7 +41,7 @@ class GDataEntry {
virtual GDataDirectory* AsGDataDirectory();
// Initializes from DocumentEntry.
- virtual void InitFromDocumentEntry(DocumentEntry* doc);
+ virtual void InitFromDocumentEntry(const DocumentEntry& doc);
// const versions of AsGDataFile and AsGDataDirectory.
const GDataFile* AsGDataFileConst() const;
@@ -201,7 +201,7 @@ class GDataFile : public GDataEntry {
explicit GDataFile(GDataDirectoryService* directory_service);
// Initializes from DocumentEntry.
- virtual void InitFromDocumentEntry(DocumentEntry* doc) OVERRIDE;
+ virtual void InitFromDocumentEntry(const DocumentEntry& doc) OVERRIDE;
virtual GDataFile* AsGDataFile() OVERRIDE;
@@ -243,7 +243,7 @@ class GDataDirectory : public GDataEntry {
explicit GDataDirectory(GDataDirectoryService* directory_service);
// Initializes from DocumentEntry.
- virtual void InitFromDocumentEntry(DocumentEntry* doc) OVERRIDE;
+ virtual void InitFromDocumentEntry(const DocumentEntry& doc) OVERRIDE;
virtual GDataDirectory* AsGDataDirectory() OVERRIDE;
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system.cc ('k') | chrome/browser/chromeos/gdata/gdata_files.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698