chrome/browser/chromeos/gdata/gdata_directory_service.cc - Issue 10854180: Pass const ref instead of pointer for FromDocumentEntry()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_directory_service.cc

Issue 10854180: Pass const ref instead of pointer for FromDocumentEntry() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix for comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/gdata/gdata_directory_service.cc

diff --git a/chrome/browser/chromeos/gdata/gdata_directory_service.cc b/chrome/browser/chromeos/gdata/gdata_directory_service.cc

index f89ecdf24a9da3bf8283d6f2ef5e947c9357257a..26eb8221e8bc8aa979ce30b65bece90e49d2f4a0 100644

--- a/chrome/browser/chromeos/gdata/gdata_directory_service.cc

+++ b/chrome/browser/chromeos/gdata/gdata_directory_service.cc

@@ -203,12 +203,11 @@ GDataDirectoryService::~GDataDirectoryService() {

directory_service_db_.release());

}

-GDataEntry* GDataDirectoryService::FromDocumentEntry(DocumentEntry* doc) {

- DCHECK(doc);

+GDataEntry* GDataDirectoryService::FromDocumentEntry(const DocumentEntry& doc) {

GDataEntry* entry = NULL;

- if (doc->is_folder())

+ if (doc.is_folder())

entry = CreateGDataDirectory();

- else if (doc->is_hosted_document() || doc->is_file())

+ else if (doc.is_hosted_document() || doc.is_file())

entry = CreateGDataFile();

if (entry)