Move command handling and updating off Browser and onto a helper object.

Moves command handling from Browser to a new object, BrowserCommandController.

Notes:
. BrowserCommandController now owns the CommandUpdater.
. CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller.
. The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward.
. Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands.

http://crbug.com/133576
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144597

[sky, 2012-06-27 03:09:27]

http://codereview.chromium.org/10677009/diff/188/chrome/browser/command_updat...
File chrome/browser/command_updater.h (right):

http://codereview.chromium.org/10677009/diff/188/chrome/browser/command_updat...
chrome/browser/command_updater.h:16: public:
nit: spacing is off here and 21.

Also, I think this class should be in its own header. But that can be done
later.

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (left):

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:240: bool HasInternalURL(const NavigationEntry*
entry) {
Can this be remove from browser.cc now?

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:2862: case
chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED: {
This looks like it was removed from both. Don't we need it?

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_command_controller.cc (right):

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_command_controller.cc:632: }
Don't you need to AddInterstitialObservers(new_contents) here?

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_commands.cc (right):

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:202: ||
current_tab->ShowingInterstitialPage())
nit: || on previous line.

http://codereview.chromium.org/10677009/diff/188/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:415: return service ?
!service->entries().empty() : false;
nit: return service && !service->entries().empty();

[Ben Goodger (Google), 2012-06-27 16:28:51]

Updated.

[sky, 2012-06-27 16:55:18]

LGTM