chrome/browser/automation/automation_provider.cc - Issue 10677009: Move command handling and updating off Browser and onto a helper object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/automation/automation_provider.cc

===================================================================

--- chrome/browser/automation/automation_provider.cc (revision 144460)

+++ chrome/browser/automation/automation_provider.cc (working copy)

@@ -46,6 +46,7 @@

#include "chrome/browser/ssl/ssl_blocking_page.h"

#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"

#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h"

+#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/find_bar/find_bar.h"

@@ -560,8 +561,7 @@

// If the browser has UI, simulate what a user would do.

// Activate the tab and then click the encoding menu.

- if (browser &&

- browser->command_updater()->IsCommandEnabled(IDC_ENCODING_MENU)) {

+ if (browser && chrome::IsCommandEnabled(browser, IDC_ENCODING_MENU)) {

int selected_encoding_id =

CharacterEncoding::GetCommandIdByCanonicalEncodingName(encoding_name);

if (selected_encoding_id) {

« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/automation/testing_automation_provider.cc » ('j') | no next file with comments »