Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: chrome/browser/command_updater.h

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/command_observer.h ('k') | chrome/browser/command_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/command_updater.h
===================================================================
--- chrome/browser/command_updater.h (revision 144460)
+++ chrome/browser/command_updater.h (working copy)
@@ -10,6 +10,8 @@
#include "base/hash_tables.h"
#include "webkit/glue/window_open_disposition.h"
+class CommandObserver;
+
////////////////////////////////////////////////////////////////////////////////
//
// CommandUpdater class
@@ -48,29 +50,16 @@
// Performs the action associated with this command ID using CURRENT_TAB
// disposition.
- // TODO(beng): get rid of this since it's effectively just a pass-thru and the
- // call sites would be better off using more well defined delegate interfaces.
- void ExecuteCommand(int id);
+ // Returns true if the command was executed (i.e. it is supported and is
+ // enabled).
+ bool ExecuteCommand(int id);
// Performs the action associated with this command ID using the given
// disposition.
- // TODO(altimofeev): refactor the interface to provide more flexible and
- // explicit way for passing command specific arguments. See
- // NotificationDetails class for the possible implementation ideas.
- void ExecuteCommandWithDisposition(int id, WindowOpenDisposition disposition);
+ // Returns true if the command was executed (i.e. it is supported and is
+ // enabled).
+ bool ExecuteCommandWithDisposition(int id, WindowOpenDisposition disposition);
- // An Observer interface implemented by objects that want to be informed when
- // the state of a particular command ID is modified.
- class CommandObserver {
- public:
- // Notifies the observer that the enabled state has changed for the
- // specified command id.
- virtual void EnabledStateChangedForCommand(int id, bool enabled) = 0;
-
- protected:
- virtual ~CommandObserver();
- };
-
// Adds an observer to the state of a particular command. If the command does
// not exist, it is created, initialized to false.
void AddCommandObserver(int id, CommandObserver* observer);
« no previous file with comments | « chrome/browser/command_observer.h ('k') | chrome/browser/command_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698