Move command handling and updating off Browser and onto a helper object.

chrome/browser/sync/sync_global_error_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_global_error.h"
 
 #include "base/basictypes.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/signin/signin_manager.h"
@@ skipping 87 matching lines @@
   EXPECT_NE(error->MenuItemCommandID(), 0);
   EXPECT_NE(error->MenuItemLabel().empty(), is_error);
   EXPECT_NE(error->GetBubbleViewAcceptButtonLabel().empty(), is_error);
 
   // We never have a cancel button.
   EXPECT_TRUE(error->GetBubbleViewCancelButtonLabel().empty());
   // We always return a hardcoded title.
   EXPECT_FALSE(error->GetBubbleViewTitle().empty());
 
 #if defined(OS_CHROMEOS)
+  // TODO(altimofeev): Implement this in a way that doesn't involve subclassing
+  //                   Browser or using GMock on browser/ui types which is
+  //                   banned. Consider observing NOTIFICATION_APP_TERMINATING
+  //                   instead.
+  //                   http://crbug.com/134675
+#else
+#if defined(OS_CHROMEOS)
   if (error_state != GoogleServiceAuthError::NONE) {
     // In CrOS sign-in/sign-out is made to fix the error.
     EXPECT_CALL(*static_cast<BrowserMock*>(browser),
                 ExecuteCommandWithDisposition(IDC_EXIT, _));
     error->ExecuteMenuItem(browser);
   }
 #else
   // Test message handler.
   if (is_error) {
     EXPECT_CALL(*login_ui_service, ShowLoginUI());
     error->ExecuteMenuItem(browser);
     EXPECT_CALL(*login_ui_service, ShowLoginUI());
     error->BubbleViewAcceptButtonPressed(browser);
     error->BubbleViewDidClose(browser);
   }
 #endif
+#endif
 }
 
 } // namespace
 
 // Test that SyncGlobalError shows an error if a passphrase is required.
 TEST_F(SyncGlobalErrorTest, PassphraseGlobalError) {
   scoped_ptr<Profile> profile(
       ProfileSyncServiceMock::MakeSignedInTestingProfile());
   NiceMock<ProfileSyncServiceMock> service(profile.get());
   SigninManager* signin = SigninManagerFactory::GetForProfile(profile.get());
@@ skipping 49 matching lines @@
     { GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },
   };
 
   for (size_t i = 0; i < sizeof(table)/sizeof(*table); ++i) {
     VerifySyncGlobalErrorResult(&service, login_ui_service, browser(), &error,
                                 table[i].error_state, true, table[i].is_error);
     VerifySyncGlobalErrorResult(&service, login_ui_service, browser(), &error,
                                 table[i].error_state, false, false);
   }
 }