Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: chrome/browser/ui/browser_unittest.cc

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/cocoa/browser/avatar_button_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_unittest.cc
===================================================================
--- chrome/browser/ui/browser_unittest.cc (revision 144460)
+++ chrome/browser/ui/browser_unittest.cc (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_window_state.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "content/public/browser/native_web_keyboard_event.h"
@@ -36,8 +37,10 @@
0,
base::Time::Now().ToDoubleT());
// F1-4 keys are reserved on Chrome OS.
- EXPECT_TRUE(browser()->IsReservedCommandOrKey(IDC_BACK, event));
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(IDC_BACK,
+ event));
// ..unless |command_id| is -1. crbug.com/122978
- EXPECT_FALSE(browser()->IsReservedCommandOrKey(-1, event));
+ EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(-1,
+ event));
#endif
}
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/cocoa/browser/avatar_button_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698