chrome/browser/ui/cocoa/browser_window_utils.mm - Issue 10677009: Move command handling and updating off Browser and onto a helper object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_utils.mm

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_utils.mm

===================================================================

--- chrome/browser/ui/cocoa/browser_window_utils.mm (revision 144460)

+++ chrome/browser/ui/cocoa/browser_window_utils.mm (working copy)

@@ -66,7 +66,8 @@

// "Close window" doesn't use the |commandDispatch:| mechanism. Menu items

// that do not correspond to IDC_ constants need no special treatment however,

- // as they can't be blacklisted in |Browser::IsReservedCommandOrKey()| anyhow.

+ // as they can't be blacklisted in

+ // |BrowserCommandController::IsReservedCommandOrKey()| anyhow.

if (item && [item action] == @selector(performClose:))

return IDC_CLOSE_WINDOW;

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/command_observer_bridge.h » ('j') | no next file with comments »