chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 10677009: Move command handling and updating off Browser and onto a helper object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 10677009: Move command handling and updating off Browser and onto a helper object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser/avatar_button_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

===================================================================

--- chrome/browser/ui/cocoa/browser_window_cocoa.mm (revision 144460)

+++ chrome/browser/ui/cocoa/browser_window_cocoa.mm (working copy)

@@ -16,6 +16,7 @@

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_command_controller.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window_state.h"

#import "chrome/browser/ui/cocoa/browser/avatar_button_controller.h"

@@ -509,7 +510,7 @@

if (id == -1)

return false;

- if (browser_->IsReservedCommandOrKey(id, event)) {

+ if (browser_->command_controller()->IsReservedCommandOrKey(id, event)) {

return [BrowserWindowUtils handleKeyboardEvent:event.os_event

inWindow:window()];

}