Issue 10459058: Define a baseline and testing patterns for ARM load_store_word_byte table.

Issue 10459058: Define a baseline and testing patterns for ARM load_store_word_byte table. (Closed)

Created:
8 years, 6 months ago by Karl

Modified:
8 years, 6 months ago

Reviewers:
sehr (please use chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

Define a baseline and testing patterns for ARM load_store_word_byte table. Also deals with stores with writeback and Rn=Rt. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2816 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8813

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1626 lines, -429 lines)			Patch
M	src/trusted/validator_arm/actual_classes.cc	View	1 2	4 chunks	+26 lines, -7 lines	0 comments	Download
M	src/trusted/validator_arm/armv7.table	View	1 2	5 chunks	+60 lines, -28 lines	0 comments	Download
M	src/trusted/validator_arm/baseline_classes.h	View	1 2	11 chunks	+228 lines, -36 lines	0 comments	Download
M	src/trusted/validator_arm/baseline_classes.cc	View	1 2	6 chunks	+155 lines, -21 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode.h	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode.cc	View	1 2	4 chunks	+9 lines, -12 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named.cc	View	1 2	4 chunks	+109 lines, -32 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named_classes.h	View	1 2	19 chunks	+470 lines, -147 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named_decoder.h	View	1 2	4 chunks	+30 lines, -13 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_tests.cc	View	1 2	8 chunks	+240 lines, -70 lines	0 comments	Download
M	src/trusted/validator_arm/inst_classes_testers.h	View	1 2	3 chunks	+99 lines, -17 lines	0 comments	Download
M	src/trusted/validator_arm/inst_classes_testers.cc	View	1 2	6 chunks	+199 lines, -42 lines	0 comments	Download
M	src/trusted/validator_arm/testdata/test_loads.err	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

One nit. LGTM otherwise. https://chromiumcodereview.appspot.com/10459058/diff/22001/src/trusted/validator_arm/baseline_classes.h File src/trusted/validator_arm/baseline_classes.h (right): https://chromiumcodereview.appspot.com/10459058/diff/22001/src/trusted/validator_arm/baseline_classes.h#newcode456 src/trusted/validator_arm/baseline_classes.h:456: // Note: We NaCl disallow ...

8 years, 6 months ago (2012-06-05 20:16:19 UTC) #2

Karl

8 years, 6 months ago (2012-06-05 20:42:16 UTC) #3

https://chromiumcodereview.appspot.com/10459058/diff/22001/src/trusted/valida...
File src/trusted/validator_arm/baseline_classes.h (right):

https://chromiumcodereview.appspot.com/10459058/diff/22001/src/trusted/valida...
src/trusted/validator_arm/baseline_classes.h:456: // Note: We NaCl disallow
Rt=PC for stores (not just loads), even
On 2012/06/05 20:16:20, sehr wrote:
> NaCl disallows?

Done.

Expand Messages | Collapse Messages