Issue 10356115: Clean up code to clarify we are only tracking the condition flags of APSR.

Issue 10356115: Clean up code to clarify we are only tracking the condition flags of APSR. (Closed)

Created:
8 years, 7 months ago by Karl

Modified:
8 years, 7 months ago

Reviewers:
sehr (please use chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

Clean up code to clarify we are only tracking the condition flags of APSR. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2673 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8589

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -131 lines)			Patch
M	src/trusted/validator_arm/actual_classes.h	View	1	6 chunks	+11 lines, -4 lines	0 comments	Download
M	src/trusted/validator_arm/actual_classes.cc	View	1	8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/trusted/validator_arm/actual_classes_statics.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/validator_arm/baseline_classes.h	View	1	11 chunks	+11 lines, -11 lines	0 comments	Download
M	src/trusted/validator_arm/baseline_classes.cc	View	1	12 chunks	+12 lines, -12 lines	0 comments	Download
M	src/trusted/validator_arm/baseline_classes_statics.cc	View	1	2 chunks	+18 lines, -28 lines	0 comments	Download
M	src/trusted/validator_arm/inst_classes.h	View	1	2 chunks	+15 lines, -9 lines	0 comments	Download
M	src/trusted/validator_arm/inst_classes_testers.cc	View	1	17 chunks	+61 lines, -50 lines	0 comments	Download
M	src/trusted/validator_arm/model.h	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/trusted/validator_arm/validator.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/trusted/validator_arm/validator.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

Couple of grammar nits. LGTM if fixed. http://codereview.chromium.org/10356115/diff/1/src/trusted/validator_arm/model.h File src/trusted/validator_arm/model.h (right): http://codereview.chromium.org/10356115/diff/1/src/trusted/validator_arm/model.h#newcode83 src/trusted/validator_arm/model.h:83: // The ...

8 years, 7 months ago (2012-05-14 19:48:12 UTC) #2

Karl

8 years, 7 months ago (2012-05-14 21:09:50 UTC) #3

https://chromiumcodereview.appspot.com/10356115/diff/1/src/trusted/validator_...
File src/trusted/validator_arm/model.h (right):

https://chromiumcodereview.appspot.com/10356115/diff/1/src/trusted/validator_...
src/trusted/validator_arm/model.h:83: // The conditions (i.e. APSR N, Z, C, and
V) is modeled as r16.
On 2012/05/14 19:48:12, sehr wrote:
> conditions are collectively modeled as ...

Done.

https://chromiumcodereview.appspot.com/10356115/diff/1/src/trusted/validator_...
src/trusted/validator_arm/model.h:84: // These bits of the APSR flag are
separately tracked, so we can
On 2012/05/14 19:48:12, sehr wrote:
> APSR register rather than flag?

Done.

Expand Messages | Collapse Messages