Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Unified Diff: src/trusted/validator_arm/model.h

Issue 10356115: Clean up code to clarify we are only tracking the condition flags of APSR. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/inst_classes_testers.cc ('k') | src/trusted/validator_arm/validator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/model.h
===================================================================
--- src/trusted/validator_arm/model.h (revision 8588)
+++ src/trusted/validator_arm/model.h (working copy)
@@ -80,15 +80,18 @@
*/
const Register kRegisterNone(31);
-// The APSR (flags register) is modeled as r16.
-const Register kRegisterFlags(16);
+// The conditions (i.e. APSR N, Z, C, and V) are collectively modeled as r16.
+// These bits of the APSR register are separately tracked, so we can
+// test when any of the 4 bits (and hence conditional execution) is
+// affected. If you need to track other bits in the APSR, add them as
+// a separate register.
+const Register kConditions(16);
// Registers with special meaning in our model:
const Register kRegisterPc(15);
const Register kRegisterLink(14);
const Register kRegisterStack(13);
-
/*
* A collection of Registers. Used to describe the side effects of operations.
*
« no previous file with comments | « src/trusted/validator_arm/inst_classes_testers.cc ('k') | src/trusted/validator_arm/validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698