Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/trusted/validator_arm/actual_classes.cc

Issue 10356115: Clean up code to clarify we are only tracking the condition flags of APSR. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/actual_classes.h ('k') | src/trusted/validator_arm/actual_classes_statics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/actual_classes.cc
===================================================================
--- src/trusted/validator_arm/actual_classes.cc (revision 8588)
+++ src/trusted/validator_arm/actual_classes.cc (working copy)
@@ -18,7 +18,7 @@
// N E W C L A S S D E C O D E R S
// **************************************************************
-// Data processing and arithmetic
+// Defs12To15
SafetyLevel Defs12To15::safety(const Instruction i) const {
if (defs(i)[kRegisterPc]) {
return FORBIDDEN_OPERANDS;
@@ -27,7 +27,7 @@
}
RegisterList Defs12To15::defs(const Instruction i) const {
- return d.reg(i) + flags.reg_if_updated(i);
+ return d.reg(i) + conditions.conds_if_updated(i);
}
SafetyLevel Defs12To15RdRnRsRmNotPc::safety(const Instruction i) const {
@@ -60,11 +60,11 @@
}
RegisterList DataProc::defs(const Instruction i) const {
- return Rd(i) + (UpdatesFlagsRegister(i) ? kRegisterFlags : kRegisterNone);
+ return Rd(i) + (UpdatesConditions(i) ? kConditions : kRegisterNone);
}
RegisterList Test::defs(const Instruction i) const {
- return (UpdatesFlagsRegister(i) ? kRegisterFlags : kRegisterNone);
+ return (UpdatesConditions(i) ? kConditions : kRegisterNone);
}
@@ -74,7 +74,7 @@
// Rn = 19:16 for TST(immediate) - section A8.6.230
return Rn(i) == r
&& (imm12.get_modified_immediate(i) & mask) == mask
- && defs(i)[kRegisterFlags];
+ && defs(i)[kConditions];
}
@@ -91,7 +91,7 @@
}
RegisterList PackSatRev::defs(const Instruction i) const {
- return Rd(i) + kRegisterFlags;
+ return Rd(i) + kConditions;
}
@@ -103,7 +103,7 @@
}
RegisterList Multiply::defs(const Instruction i) const {
- return kRegisterFlags + Rd(i);
+ return kConditions + Rd(i);
}
@@ -113,7 +113,7 @@
RegisterList SatAddSub::defs(const Instruction i) const {
- return DataProc::defs(i) + kRegisterFlags;
+ return DataProc::defs(i) + kConditions;
}
@@ -121,7 +121,7 @@
RegisterList MoveToStatusRegister::defs(const Instruction i) const {
UNREFERENCED_PARAMETER(i);
- return kRegisterFlags;
+ return kConditions;
}
« no previous file with comments | « src/trusted/validator_arm/actual_classes.h ('k') | src/trusted/validator_arm/actual_classes_statics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698