Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 2692853016: Change PaintLayer::m_layoutObject to a reference. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by szager1
Modified:
5 months ago
Reviewers:
chrishtr, pdr.
CC:
apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dshwang, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change PaintLayer::m_layoutObject to a reference. PaintLayer::layoutObject() and CompositedLayerMapping::layoutObject() now return references, and various other methods now take references rather than pointers as arguments. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2692853016 Cr-Commit-Position: refs/heads/master@{#451361} Committed: https://chromium.googlesource.com/chromium/src/+/f903348fa83ee0e48eb45a1b850bcd16ab230392

Patch Set 1 #

Patch Set 2 : restore inadvertantly removed null check #

Total comments: 4

Patch Set 3 : Added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -679 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 6 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 5 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 6 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 70 chunks +171 lines, -173 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 10 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp View 4 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 10 chunks +18 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxReflectionUtils.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 10 chunks +17 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 87 chunks +180 lines, -174 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 12 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 26 chunks +50 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 7 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 28 (19 generated)
szager1
5 months ago (2017-02-17 16:18:03 UTC) #13
chrishtr
https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (left): https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#oldcode579 third_party/WebKit/Source/core/paint/PaintLayer.cpp:579: if (!transformedAncestor) ditto https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode557 third_party/WebKit/Source/core/paint/PaintLayer.cpp:557: ...
5 months ago (2017-02-17 17:23:07 UTC) #15
chrishtr
https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode557 third_party/WebKit/Source/core/paint/PaintLayer.cpp:557: paintInvalidationLayer->enclosingTransformedAncestor()->layoutObject(); On 2017/02/17 at 17:23:07, chrishtr wrote: > This ...
5 months ago (2017-02-17 17:24:07 UTC) #16
pdr.
LGTM
5 months ago (2017-02-17 17:37:09 UTC) #17
szager1
https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right): https://codereview.chromium.org/2692853016/diff/20001/third_party/WebKit/Source/core/paint/PaintLayer.cpp#newcode557 third_party/WebKit/Source/core/paint/PaintLayer.cpp:557: paintInvalidationLayer->enclosingTransformedAncestor()->layoutObject(); On 2017/02/17 17:24:07, chrishtr wrote: > On 2017/02/17 ...
5 months ago (2017-02-17 18:06:26 UTC) #18
chrishtr
lgtm Ok just add a todo.
5 months ago (2017-02-17 18:08:38 UTC) #20
szager1
On 2017/02/17 18:08:38, chrishtr wrote: > lgtm > > Ok just add a todo. I ...
5 months ago (2017-02-17 18:18:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692853016/40001
5 months ago (2017-02-17 18:18:44 UTC) #25
commit-bot: I haz the power
5 months ago (2017-02-17 19:58:25 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f903348fa83ee0e48eb45a1b850b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973