Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Issue 2692853016: Change PaintLayer::m_layoutObject to a reference. (Closed)
Patch Set: Added TODO Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/inspector/InspectorTraceEvents.h" 5 #include "core/inspector/InspectorTraceEvents.h"
6 6
7 #include "bindings/core/v8/ScriptSourceCode.h" 7 #include "bindings/core/v8/ScriptSourceCode.h"
8 #include "bindings/core/v8/SourceLocation.h" 8 #include "bindings/core/v8/SourceLocation.h"
9 #include "core/animation/Animation.h" 9 #include "core/animation/Animation.h"
10 #include "core/animation/KeyframeEffectReadOnly.h" 10 #include "core/animation/KeyframeEffectReadOnly.h"
(...skipping 758 matching lines...) Expand 10 before | Expand all | Expand 10 after
769 "Removed the layer from a squashing layer"; 769 "Removed the layer from a squashing layer";
770 const char InspectorLayerInvalidationTrackingEvent::ReflectionLayerChanged[] = 770 const char InspectorLayerInvalidationTrackingEvent::ReflectionLayerChanged[] =
771 "Reflection layer change"; 771 "Reflection layer change";
772 const char InspectorLayerInvalidationTrackingEvent::NewCompositedLayer[] = 772 const char InspectorLayerInvalidationTrackingEvent::NewCompositedLayer[] =
773 "Assigned a new composited layer"; 773 "Assigned a new composited layer";
774 774
775 std::unique_ptr<TracedValue> InspectorLayerInvalidationTrackingEvent::data( 775 std::unique_ptr<TracedValue> InspectorLayerInvalidationTrackingEvent::data(
776 const PaintLayer* layer, 776 const PaintLayer* layer,
777 const char* reason) { 777 const char* reason) {
778 const LayoutObject& paintInvalidationContainer = 778 const LayoutObject& paintInvalidationContainer =
779 layer->layoutObject()->containerForPaintInvalidation(); 779 layer->layoutObject().containerForPaintInvalidation();
780 780
781 std::unique_ptr<TracedValue> value = TracedValue::create(); 781 std::unique_ptr<TracedValue> value = TracedValue::create();
782 value->setString("frame", toHexString(paintInvalidationContainer.frame())); 782 value->setString("frame", toHexString(paintInvalidationContainer.frame()));
783 setGeneratingNodeInfo(value.get(), &paintInvalidationContainer, "paintId"); 783 setGeneratingNodeInfo(value.get(), &paintInvalidationContainer, "paintId");
784 value->setString("reason", reason); 784 value->setString("reason", reason);
785 return value; 785 return value;
786 } 786 }
787 787
788 std::unique_ptr<TracedValue> InspectorPaintEvent::data( 788 std::unique_ptr<TracedValue> InspectorPaintEvent::data(
789 LayoutObject* layoutObject, 789 LayoutObject* layoutObject,
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 if (request.move()) 1071 if (request.move())
1072 value->setBoolean("move", true); 1072 value->setBoolean("move", true);
1073 if (request.listBased()) 1073 if (request.listBased())
1074 value->setBoolean("listBased", true); 1074 value->setBoolean("listBased", true);
1075 else if (Node* node = result.innerNode()) 1075 else if (Node* node = result.innerNode())
1076 setNodeInfo(value.get(), node, "nodeId", "nodeName"); 1076 setNodeInfo(value.get(), node, "nodeId", "nodeName");
1077 return value; 1077 return value;
1078 } 1078 }
1079 1079
1080 } // namespace blink 1080 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698