Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2692853016: Change PaintLayer::m_layoutObject to a reference. (Closed)
Patch Set: Added TODO Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
9 * rights reserved. 9 * rights reserved.
10 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 10 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 // itself. This will also paint the contents behind the object if the 210 // itself. This will also paint the contents behind the object if the
211 // object contains transparency and there are other elements in the same 211 // object contains transparency and there are other elements in the same
212 // stacking context which stacked below. 212 // stacking context which stacked below.
213 PaintLayer* layer = draggedLayoutObject->enclosingLayer(); 213 PaintLayer* layer = draggedLayoutObject->enclosingLayer();
214 if (!layer->stackingNode()->isStackingContext()) 214 if (!layer->stackingNode()->isStackingContext())
215 layer = layer->stackingNode()->ancestorStackingContextNode()->layer(); 215 layer = layer->stackingNode()->ancestorStackingContextNode()->layer();
216 IntRect absoluteBoundingBox = 216 IntRect absoluteBoundingBox =
217 draggedLayoutObject->absoluteBoundingBoxRectIncludingDescendants(); 217 draggedLayoutObject->absoluteBoundingBoxRectIncludingDescendants();
218 FloatRect boundingBox = 218 FloatRect boundingBox =
219 layer->layoutObject() 219 layer->layoutObject()
220 ->absoluteToLocalQuad(FloatQuad(absoluteBoundingBox), UseTransforms) 220 .absoluteToLocalQuad(FloatQuad(absoluteBoundingBox), UseTransforms)
221 .boundingBox(); 221 .boundingBox();
222 DragImageBuilder dragImageBuilder(*m_localFrame, boundingBox); 222 DragImageBuilder dragImageBuilder(*m_localFrame, boundingBox);
223 { 223 {
224 PaintLayerPaintingInfo paintingInfo(layer, LayoutRect(boundingBox), 224 PaintLayerPaintingInfo paintingInfo(layer, LayoutRect(boundingBox),
225 GlobalPaintFlattenCompositingLayers, 225 GlobalPaintFlattenCompositingLayers,
226 LayoutSize()); 226 LayoutSize());
227 PaintLayerFlags flags = PaintLayerHaveTransparency | 227 PaintLayerFlags flags = PaintLayerHaveTransparency |
228 PaintLayerAppliedTransform | 228 PaintLayerAppliedTransform |
229 PaintLayerUncachedClipRects; 229 PaintLayerUncachedClipRects;
230 PaintLayerPainter(*layer).paint(dragImageBuilder.context(), paintingInfo, 230 PaintLayerPainter(*layer).paint(dragImageBuilder.context(), paintingInfo,
(...skipping 686 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext()) 917 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
918 m_frame->client()->frameBlameContext()->Enter(); 918 m_frame->client()->frameBlameContext()->Enter();
919 } 919 }
920 920
921 ScopedFrameBlamer::~ScopedFrameBlamer() { 921 ScopedFrameBlamer::~ScopedFrameBlamer() {
922 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext()) 922 if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
923 m_frame->client()->frameBlameContext()->Leave(); 923 m_frame->client()->frameBlameContext()->Leave();
924 } 924 }
925 925
926 } // namespace blink 926 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698