third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp - Issue 2692853016: Change PaintLayer::m_layoutObject to a reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

Issue 2692853016: Change PaintLayer::m_layoutObject to a reference. (Closed)

Patch Set: Added TODO Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

index ff5fcfb32b3d85c048e3d11154f5c79a113ee89f..eb19818c2295ec0f667aec27629b3e0cdc25bb07 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

@@ -248,7 +248,7 @@ void InspectorLayerTreeAgent::buildLayerIdToNodeIdMap(

PaintLayer* root,

LayerIdToNodeIdMap& layerIdToNodeIdMap) {

if (root->hasCompositedLayerMapping()) {

- if (Node* node = root->layoutObject()->generatingNode()) {

+ if (Node* node = root->layoutObject().generatingNode()) {

GraphicsLayer* graphicsLayer =

root->compositedLayerMapping()->childForSuperlayers();

layerIdToNodeIdMap.set(graphicsLayer->platformLayer()->id(),

@@ -258,10 +258,10 @@ void InspectorLayerTreeAgent::buildLayerIdToNodeIdMap(

for (PaintLayer* child = root->firstChild(); child;

child = child->nextSibling())

buildLayerIdToNodeIdMap(child, layerIdToNodeIdMap);

- if (!root->layoutObject()->isLayoutIFrame())

+ if (!root->layoutObject().isLayoutIFrame())

return;

FrameView* childFrameView =

- toFrameView(toLayoutPart(root->layoutObject())->widget());

+ toFrameView(toLayoutPart(root->layoutObject()).widget());

LayoutViewItem childLayoutViewItem = childFrameView->layoutViewItem();

if (!childLayoutViewItem.isNull()) {

if (PaintLayerCompositor* childCompositor =