Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. (Closed)

Created:
7 years, 3 months ago by dtu
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. file:///a/b/c.html == absolute path. This follows RFC-1738 (empty hostname refers to localhost). file://a/b/c.html == relative path. In the RFC, "a" is technically the hostname, but we're just gonna use it as part of the path. http_server: - Support relative paths at the command-line for memory_cache_http_server. - Removal of duplicate paths. - Correct path prefix calculation. (commonprefix is a string prefix, not a path prefix.) - Correct UrlOf so it works based on path, not on an assumption that serving_dirs_and_file returns a specific value. page: - Remove _UrlPathJoin. Its behavior is awkward for absolute paths. Its backslash to slash conversion should be unnecessary if we always use proper OS paths (except in UrlOf). - Split serving_dirs_and_file into page.file_path, page.serving_dir, and page_set.serving_dirs. BUG=None. TEST=tools/telemetry/run_tests; tools/perf/run_tests; tools/perf/run_measurement blink_perf_all; tools/perf/run_benchmark sunspider; content/test/gpu/run_gpu_test webgl_conformance Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228869

Patch Set 1 : #

Patch Set 2 : Fix paths in unit tests on Windows. #

Patch Set 3 : Merge. #

Patch Set 4 : Fix unit test on mac, apparently /tmp is a symlink to /private/tmp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -479 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/pixel_tests.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/blank_page.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/image_decoding_measurement.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/page_cycler/alexa_us.json View 1 chunk +20 lines, -20 lines 0 comments Download
M tools/perf/page_sets/page_cycler/bloat.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/dhtml.json View 1 chunk +17 lines, -17 lines 0 comments Download
M tools/perf/page_sets/page_cycler/dom.json View 1 chunk +9 lines, -9 lines 0 comments Download
M tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/intl1.json View 1 chunk +56 lines, -56 lines 0 comments Download
M tools/perf/page_sets/page_cycler/intl2.json View 1 chunk +30 lines, -30 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejs.json View 1 chunk +9 lines, -9 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejsnp.json View 1 chunk +9 lines, -9 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz.json View 1 chunk +41 lines, -41 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz2.json View 1 chunk +41 lines, -41 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases.json View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.json View 1 chunk +7 lines, -7 lines 0 comments Download
M tools/perf/page_sets/tough_scrolling_cases.json View 1 chunk +9 lines, -9 lines 0 comments Download
M tools/perf/page_sets/tough_texture_upload_cases.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases.json View 1 2 3 1 chunk +16 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/memory_cache_http_server.py View 3 chunks +46 lines, -25 lines 0 comments Download
M tools/telemetry/telemetry/core/temporary_http_server.py View 3 chunks +12 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page.py View 3 chunks +41 lines, -61 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest_base.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 3 chunks +22 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 1 2 3 4 chunks +18 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 7 chunks +55 lines, -69 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dtu
7 years, 2 months ago (2013-10-08 22:37:34 UTC) #1
Ken Russell (switch to Gerrit)
content/test/gpu LGTM assuming the test expectations still apply correctly with these changes.
7 years, 2 months ago (2013-10-08 22:47:33 UTC) #2
tonyg
lgtm I'm super excited to see that UrlPathJoin badness go away.
7 years, 2 months ago (2013-10-10 00:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/24451002/84001
7 years, 2 months ago (2013-10-11 20:31:50 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=176794
7 years, 2 months ago (2013-10-11 23:08:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/24451002/125001
7 years, 2 months ago (2013-10-14 22:20:18 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=177183
7 years, 2 months ago (2013-10-14 23:43:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/24451002/152001
7 years, 2 months ago (2013-10-16 00:57:22 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 05:47:40 UTC) #9
Message was sent while issue was closed.
Change committed as 228869

Powered by Google App Engine
This is Rietveld 408576698