tools/telemetry/telemetry/page/page_measurement_unittest.py - Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest.py

Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test on mac, apparently /tmp is a symlink to /private/tmp Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest.py b/tools/telemetry/telemetry/page/page_measurement_unittest.py

index c30865e983abc93d2b01760d0729ba8edfba144f..49d434bfa14f5c0b436a64d7b7e3a2fd69794b98 100644

--- a/tools/telemetry/telemetry/page/page_measurement_unittest.py

+++ b/tools/telemetry/telemetry/page/page_measurement_unittest.py

@@ -65,7 +65,7 @@ class PageMeasurementUnitTest(

def disabled_testGotQueryParams(self):

# Disabled due to http://crbug.com/288631

- ps = self.CreatePageSet('file:///blank.html?foo=1')

+ ps = self.CreatePageSet('file://blank.html?foo=1')

measurement = MeasurementQueryParams()

ps.pages[-1].query_params = '?foo=1'

all_results = self.RunMeasurement(measurement, ps, options=self._options)

« no previous file with comments | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/page_measurement_unittest_base.py » ('j') | no next file with comments »