tools/telemetry/telemetry/page/page_measurement_unittest_base.py - Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest_base.py

Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test on mac, apparently /tmp is a symlink to /private/tmp Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_measurement_unittest_base.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py b/tools/telemetry/telemetry/page/page_measurement_unittest_base.py

index 389f057e475aa3b2cf2dfea748f907183687f4c3..65d97f520deb78bbaf36f205e8fe0b52473628c2 100644

--- a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py

+++ b/tools/telemetry/telemetry/page/page_measurement_unittest_base.py

@@ -16,7 +16,7 @@ class PageMeasurementUnitTestBase(unittest.TestCase):

for a measurement."""

def CreatePageSetFromFileInUnittestDataDir(self, test_filename):

- return self.CreatePageSet('file:///' + test_filename)

+ return self.CreatePageSet('file://' + test_filename)

def CreatePageSet(self, test_filename):

base_dir = util.GetUnittestDataDir()

« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_unittest.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »