tools/telemetry/telemetry/page/actions/navigate.py - Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/navigate.py

Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test on mac, apparently /tmp is a symlink to /private/tmp Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/navigate.py

diff --git a/tools/telemetry/telemetry/page/actions/navigate.py b/tools/telemetry/telemetry/page/actions/navigate.py

index 73fb320b67062fcca2fa9ae9e719f14674c23786..fc82ffe7314fc76e92d0dcbcd3afd8c100519bad 100644

--- a/tools/telemetry/telemetry/page/actions/navigate.py

+++ b/tools/telemetry/telemetry/page/actions/navigate.py

@@ -11,10 +11,9 @@ class NavigateAction(page_action.PageAction):

def RunAction(self, page, tab, previous_action):

if page.is_file:

- filename = page.serving_dirs_and_file[1]

- target_side_url = tab.browser.http_server.UrlOf(filename)

+ target_side_url = tab.browser.http_server.UrlOf(page.file_path)

else:

target_side_url = page.url

tab.Navigate(target_side_url, page.script_to_evaluate_on_commit)

- tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()

+ tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()

« no previous file with comments | « tools/telemetry/telemetry/core/temporary_http_server.py ('k') | tools/telemetry/telemetry/page/page.py » ('j') | no next file with comments »