Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test on mac, apparently /tmp is a symlink to /private/tmp Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/page_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index c3d4f2b820fc7626ebedc95609af09f16c053c6b..cb423bd5ef2198fa6006c79b8b3d461417ebb91e 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -84,9 +84,9 @@ class PageRunnerTests(unittest.TestCase):
ps = page_set.PageSet()
expectations = test_expectations.TestExpectations()
ps.pages.append(page_module.Page(
- 'file:///blank.html', ps, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir()))
ps.pages.append(page_module.Page(
- 'file:///blank.html', ps, base_dir=util.GetUnittestDataDir()))
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir()))
class Measurement(page_measurement.PageMeasurement):
@property
@@ -143,7 +143,7 @@ class PageRunnerTests(unittest.TestCase):
ps = page_set.PageSet()
expectations = test_expectations.TestExpectations()
page = page_module.Page(
- 'file:///blank.html', ps, base_dir=util.GetUnittestDataDir())
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
page.credentials = "test"
ps.pages.append(page)
@@ -178,7 +178,7 @@ class PageRunnerTests(unittest.TestCase):
ps = page_set.PageSet()
expectations = test_expectations.TestExpectations()
page = page_module.Page(
- 'file:///blank.html', ps, base_dir=util.GetUnittestDataDir())
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
ps.pages.append(page)
ps.user_agent_type = 'tablet'
@@ -205,7 +205,7 @@ class PageRunnerTests(unittest.TestCase):
ps = page_set.PageSet()
expectations = test_expectations.TestExpectations()
page = page_module.Page(
- 'file:///blank.html', ps, base_dir=util.GetUnittestDataDir())
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
ps.pages.append(page)
class TestOneTab(page_test.PageTest):
@@ -239,7 +239,7 @@ class PageRunnerTests(unittest.TestCase):
ps = page_set.PageSet()
expectations = test_expectations.TestExpectations()
page = page_module.Page(
- 'file:///blank.html', ps, base_dir=util.GetUnittestDataDir())
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
ps.pages.append(page)
class TestBeforeLaunch(page_test.PageTest):
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/page_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698