tools/telemetry/telemetry/page/page_runner.py - Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 24451002: [telemetry] Support absolute paths by changing file:/// to file://. More robust file path handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test on mac, apparently /tmp is a symlink to /private/tmp Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_unittest_base.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index b968e0e5d7036404703b743ccaa8c7734a760cac..7d3b3408726dcc626152c8fdb4b90c19e77a8ee4 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -133,8 +133,9 @@ class PageState(object):

def PreparePage(self, page, tab, test=None):

if page.is_file:

- serving_dirs = page.serving_dirs_and_file[0]

- if tab.browser.SetHTTPServerDirectories(serving_dirs) and test:

+ server_started = tab.browser.SetHTTPServerDirectories(

+ page.page_set.serving_dirs | set([page.serving_dir]))

+ if server_started and test:

test.DidStartHTTPServer(tab)

if page.credentials: