Move extensions manifest IconsHandler to //extensions

Move extensions manifest IconsHandler to //extensions

Icon support is a general extension concept. This patch allows app_shell
(and eventually extension_protocol.cc) to use it.

BUG=361373
TEST=browser_tests *Extension*
TBR=sky@chromium.org for mechanical header file move across chrome

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262771

[James Cook, 2014-04-09 00:09:47]

yoz, PTAL. The only non-mechanical change is moving ValidateExtensionIconSet
from c/c/e/extension_file_utils.cc to e/c/file_utils.cc

If this looks good to you please check the CQ box.

I have a more interesting change to extension_protocol.cc that will depend on
this one https://codereview.chromium.org/229733002/

[James Cook, 2014-04-09 00:11:06]

+rockot just as FYI

[Yoyo Zhou, 2014-04-09 01:00:34]

LGTM

https://chromiumcodereview.appspot.com/229813002/diff/20001/extensions/common...
File extensions/common/manifest_handlers/icons_handler.cc (right):

https://chromiumcodereview.appspot.com/229813002/diff/20001/extensions/common...
extensions/common/manifest_handlers/icons_handler.cc:30: const int
IconsInfo::kPageActionIconMaxSize = 19;
These probably belong in ExtensionAction, not here, but that can be a separate
CL. But because this CL needs a rebase, you may as well move them.

[Yoyo Zhou, 2014-04-09 01:00:39]

LGTM, but won't CQ because Ken's patch causes this one to not patch cleanly
anymore

[James Cook, 2014-04-09 17:04:59]

https://chromiumcodereview.appspot.com/229813002/diff/20001/extensions/common...
File extensions/common/manifest_handlers/icons_handler.cc (right):

https://chromiumcodereview.appspot.com/229813002/diff/20001/extensions/common...
extensions/common/manifest_handlers/icons_handler.cc:30: const int
IconsInfo::kPageActionIconMaxSize = 19;
On 2014/04/09 01:00:34, Yoyo Zhou wrote:
> These probably belong in ExtensionAction, not here, but that can be a separate
> CL. But because this CL needs a rebase, you may as well move them.

Done. Moved kPageActionIconMaxSize. Deleted kBrowserActionIconMaxSize because it
is unused.

[James Cook, 2014-04-09 17:12:58]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-09 17:13:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/229813002/60001

[commit-bot: I haz the power, 2014-04-09 19:32:28]

Change committed as 262771