chrome/browser/extensions/extension_action.cc - Issue 229813002: Move extensions manifest IconsHandler to //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (icons-handler) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action.cc

diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc

index c7d23edfd945cc510b74a315bd5e54e0c926870f..ddf8d4f080d78a1af85f17ada06ef36abcd1c388 100644

--- a/chrome/browser/extensions/extension_action.cc

+++ b/chrome/browser/extensions/extension_action.cc

@@ -58,6 +58,7 @@ bool HasValue(const std::map<int, T>& map, int tab_id) {

} // namespace

const int ExtensionAction::kDefaultTabId = -1;

+const int ExtensionAction::kPageActionIconMaxSize = 19;

ExtensionAction::ExtensionAction(const std::string& extension_id,

extensions::ActionInfo::Type action_type,