extensions/extensions.gyp - Issue 229813002: Move extensions manifest IconsHandler to //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (icons-handler) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index eeca2c08d7a9f24d84bfb67059921c78969d91d3..4227cc0533845c94987202425c2e29b19acf7913 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -18,6 +18,9 @@

'../chrome/chrome_resources.gyp:chrome_resources',

# TODO(jamescook|derat): Pull strings into extensions module.

'../chrome/chrome_resources.gyp:chrome_strings',

+ # Need default icons in theme_resources.grd

+ '../chrome/chrome_resources.gyp:theme_resources',

# TODO(tfarina): This dep here is for extensions/common/constants.*

# We should find a way to compile this module within extensions_common.

'../chrome/common_constants.gyp:common_constants',

@@ -120,6 +123,8 @@

'common/manifest_handlers/background_info.h',

'common/manifest_handlers/csp_info.cc',

'common/manifest_handlers/csp_info.h',

+ 'common/manifest_handlers/icons_handler.cc',

+ 'common/manifest_handlers/icons_handler.h',

'common/manifest_handlers/incognito_info.cc',

'common/manifest_handlers/incognito_info.h',

'common/manifest_handlers/kiosk_mode_info.cc',

« no previous file with comments | « extensions/common/manifest_handlers/icons_handler.cc ('k') | no next file » | no next file with comments »