chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc - Issue 229813002: Move extensions manifest IconsHandler to //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (icons-handler) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/origin_chip_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

index fa761fa68883a5cdec022db2a16f9ed0b8bac1de..93a281fe19766edf2e4404feb84095adec80af69 100644

--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

@@ -4,9 +4,9 @@

#include "chrome/browser/ui/views/location_bar/page_action_with_badge_view.h"

+#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

#include "chrome/browser/ui/views/location_bar/page_action_image_view.h"

-#include "chrome/common/extensions/manifest_handlers/icons_handler.h"

#include "ui/accessibility/ax_view_state.h"

using content::WebContents;

@@ -24,8 +24,8 @@ void PageActionWithBadgeView::GetAccessibleState(

}

gfx::Size PageActionWithBadgeView::GetPreferredSize() {

- return gfx::Size(extensions::IconsInfo::kPageActionIconMaxSize,

- extensions::IconsInfo::kPageActionIconMaxSize);

+ return gfx::Size(ExtensionAction::kPageActionIconMaxSize,

+ ExtensionAction::kPageActionIconMaxSize);

}

void PageActionWithBadgeView::Layout() {