chrome/common/extensions/chrome_manifest_handlers.cc - Issue 229813002: Move extensions manifest IconsHandler to //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_handlers.cc

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (icons-handler) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/chrome_manifest_handlers.cc

diff --git a/chrome/common/extensions/chrome_manifest_handlers.cc b/chrome/common/extensions/chrome_manifest_handlers.cc

index 167499ecfd07cd583a8bfef8b947595ec020f248..877756c0691a1217745f21768af09a6a74fbede2 100644

--- a/chrome/common/extensions/chrome_manifest_handlers.cc

+++ b/chrome/common/extensions/chrome_manifest_handlers.cc

@@ -28,7 +28,6 @@

#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"

#include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"

#include "chrome/common/extensions/manifest_handlers/externally_connectable.h"

-#include "chrome/common/extensions/manifest_handlers/icons_handler.h"

#include "chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.h"

#include "chrome/common/extensions/manifest_handlers/nacl_modules_handler.h"

#include "chrome/common/extensions/manifest_handlers/settings_overrides_handler.h"

@@ -37,6 +36,7 @@

#include "chrome/common/extensions/manifest_url_handler.h"

#include "chrome/common/extensions/mime_types_handler.h"

#include "extensions/common/api/sockets/sockets_manifest_handler.h"

+#include "extensions/common/manifest_handlers/icons_handler.h"

#include "extensions/common/manifest_handlers/requirements_info.h"

namespace extensions {