chrome/browser/extensions/bookmark_app_helper_unittest.cc - Issue 229813002: Move extensions manifest IconsHandler to //extensions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/bookmark_app_helper_unittest.cc

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (icons-handler) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | chrome/browser/extensions/convert_web_app_browsertest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/bookmark_app_helper.h"	5 #include "chrome/browser/extensions/bookmark_app_helper.h"

6	6

7 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "chrome/browser/extensions/extension_service_unittest.h"	8 #include "chrome/browser/extensions/extension_service_unittest.h"

9 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"	9 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"

10 #include "chrome/common/extensions/manifest_handlers/icons_handler.h"

11 #include "chrome/test/base/testing_profile.h"	10 #include "chrome/test/base/testing_profile.h"

12 #include "extensions/browser/extension_registry.h"	11 #include "extensions/browser/extension_registry.h"

13 #include "extensions/common/extension_icon_set.h"	12 #include "extensions/common/extension_icon_set.h"

	13 #include "extensions/common/manifest_handlers/icons_handler.h"

14 #include "testing/gtest/include/gtest/gtest.h"	14 #include "testing/gtest/include/gtest/gtest.h"

15 #include "third_party/skia/include/core/SkBitmap.h"	15 #include "third_party/skia/include/core/SkBitmap.h"

16	16

17 namespace {	17 namespace {

18	18

19 #if !defined(OS_ANDROID)	19 #if !defined(OS_ANDROID)

20 const char kAppUrl[] = "http://www.chromium.org";	20 const char kAppUrl[] = "http://www.chromium.org";

21 const char kAppTitle[] = "Test title";	21 const char kAppTitle[] = "Test title";

22 const char kAlternativeAppTitle[] = "Different test title";	22 const char kAlternativeAppTitle[] = "Different test title";

23 const char kAppDescription[] = "Test description";	23 const char kAppDescription[] = "Test description";

(...skipping 228 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
252 }	252 }

253	253

254 TEST_F(BookmarkAppHelperTest, IsValidBookmarkAppUrl) {	254 TEST_F(BookmarkAppHelperTest, IsValidBookmarkAppUrl) {

255 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("https://www.chromium.org")));	255 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("https://www.chromium.org")));

256 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("http://www.chromium.org/path")));	256 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("http://www.chromium.org/path")));

257 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("ftp://www.chromium.org")));	257 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("ftp://www.chromium.org")));

258 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("chrome://flags")));	258 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("chrome://flags")));

259 }	259 }

260	260

261 } // namespace extensions	261 } // namespace extensions

OLD	NEW