Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed)

Created:
7 years, 4 months ago by dhnishi (use Chromium)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, tzik+watch_chromium.org, scheib+watch_chromium.org, nhiroki+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

c/b/extensions: Do not use Value::Create*. src/tools/json_schema_compiler: Do not use Value::Create*. BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217444

Patch Set 1 #

Patch Set 2 : Forgot to hit save on a few. #

Patch Set 3 : Remove uses of other Create* functions. #

Patch Set 4 : Trying one last time get past Base Files Missing. #

Total comments: 2

Patch Set 5 : Removed C-style casts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -366 lines) Patch
M chrome/browser/extensions/admin_policy_unittest.cc View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/discovery/discovery_api_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 2 3 4 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 2 3 4 2 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/experimental_identity_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 21 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/module/module.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 1 2 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc View 1 2 11 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/rtc_private/rtc_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.cc View 1 2 24 chunks +32 lines, -32 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_quota_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 2 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/windows_event_router.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/test/test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_request/upload_data_presenter.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 1 2 10 chunks +25 lines, -23 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_pref_value_map_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 23 chunks +31 lines, -31 lines 0 comments Download
chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_sorting.cc View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/extensions/extension_sorting_unittest.cc View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/menu_manager.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dhnishi (use Chromium)
@kalman Please take a look when you get free moment. Thanks! Daniel Nishi Cal Poly ...
7 years, 4 months ago (2013-08-12 17:20:08 UTC) #1
not at google - send to devlin
lgtm you would need to fix up other places where you've used C-style casting. https://codereview.chromium.org/22885002/diff/19001/chrome/browser/extensions/api/extension_action/extension_action_api.cc ...
7 years, 4 months ago (2013-08-12 20:59:47 UTC) #2
dhnishi (use Chromium)
C-style casts have been replaced by static_casts. https://codereview.chromium.org/22885002/diff/19001/chrome/browser/extensions/api/extension_action/extension_action_api.cc File chrome/browser/extensions/api/extension_action/extension_action_api.cc (right): https://codereview.chromium.org/22885002/diff/19001/chrome/browser/extensions/api/extension_action/extension_action_api.cc#newcode676 chrome/browser/extensions/api/extension_action/extension_action_api.cc:676: list->Append(new base::FundamentalValue((int)SkColorGetR(color))); ...
7 years, 4 months ago (2013-08-12 23:40:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/22885002/23001
7 years, 4 months ago (2013-08-13 21:31:38 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 02:14:03 UTC) #5
Message was sent while issue was closed. 
Change committed as 217444

Powered by Google App Engine
This is Rietveld 408576698