Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: chrome/browser/extensions/api/processes/processes_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/processes/processes_api.cc
diff --git a/chrome/browser/extensions/api/processes/processes_api.cc b/chrome/browser/extensions/api/processes/processes_api.cc
index e1ab2a444de30a45ee0aca66b22d57287ea7e4e1..f8c583e39d5d14b54c0050ab8a7904295d0dfe63 100644
--- a/chrome/browser/extensions/api/processes/processes_api.cc
+++ b/chrome/browser/extensions/api/processes/processes_api.cc
@@ -125,7 +125,7 @@ base::ListValue* GetTabsForProcess(int process_id) {
if (contents) {
tab_id = ExtensionTabUtil::GetTabId(contents);
if (tab_id != -1)
- tabs_list->Append(Value::CreateIntegerValue(tab_id));
+ tabs_list->Append(new base::FundamentalValue(tab_id));
}
}
@@ -401,14 +401,14 @@ void ProcessesEventRouter::OnItemsToBeRemoved(int start, int length) {
scoped_ptr<base::ListValue> args(new base::ListValue());
// First arg: The id of the process that was closed.
- args->Append(Value::CreateIntegerValue(
+ args->Append(new base::FundamentalValue(
model_->GetUniqueChildProcessId(start)));
// Second arg: The exit type for the process.
- args->Append(Value::CreateIntegerValue(0));
+ args->Append(new base::FundamentalValue(0));
// Third arg: The exit code for the process.
- args->Append(Value::CreateIntegerValue(0));
+ args->Append(new base::FundamentalValue(0));
DispatchEvent(keys::kOnExited, args.Pass());
#endif // defined(ENABLE_TASK_MANAGER)
@@ -452,13 +452,13 @@ void ProcessesEventRouter::ProcessClosedEvent(
scoped_ptr<base::ListValue> args(new base::ListValue());
// First arg: The id of the process that was closed.
- args->Append(Value::CreateIntegerValue(rph->GetID()));
+ args->Append(new base::FundamentalValue(rph->GetID()));
// Second arg: The exit type for the process.
- args->Append(Value::CreateIntegerValue(details->status));
+ args->Append(new base::FundamentalValue(details->status));
// Third arg: The exit code for the process.
- args->Append(Value::CreateIntegerValue(details->exit_code));
+ args->Append(new base::FundamentalValue(details->exit_code));
DispatchEvent(keys::kOnExited, args.Pass());
#endif // defined(ENABLE_TASK_MANAGER)
@@ -585,11 +585,11 @@ void GetProcessIdForTabFunction::GetProcessIdForTab() {
error_ = ErrorUtils::FormatErrorMessage(
extensions::tabs_constants::kTabNotFoundError,
base::IntToString(tab_id_));
- SetResult(Value::CreateIntegerValue(-1));
+ SetResult(new base::FundamentalValue(-1));
SendResponse(false);
} else {
int process_id = contents->GetRenderProcessHost()->GetID();
- SetResult(Value::CreateIntegerValue(process_id));
+ SetResult(new base::FundamentalValue(process_id));
SendResponse(true);
}
@@ -664,7 +664,7 @@ void TerminateFunction::TerminateProcess() {
base::IntToString(process_id_));
SendResponse(false);
} else {
- SetResult(Value::CreateBooleanValue(killed));
+ SetResult(new base::FundamentalValue(killed));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698