Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc b/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc
index f8307107bb1b1ab7a376dc0c3d6c0ab364148cbb..7a92fa48e8001bd231059ac582fe9508ed464c28 100644
--- a/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc
@@ -204,8 +204,8 @@ TEST(ExtensionProxyApiHelpers, GetBypassListFromExtensionPref) {
EXPECT_FALSE(bad_message);
base::ListValue* bypass_list = new base::ListValue;
- bypass_list->Append(Value::CreateStringValue("host1"));
- bypass_list->Append(Value::CreateStringValue("host2"));
+ bypass_list->Append(new base::StringValue("host1"));
+ bypass_list->Append(new base::StringValue("host2"));
base::DictionaryValue* proxy_rules = new base::DictionaryValue;
proxy_rules->Set(keys::kProxyConfigBypassList, bypass_list);
proxy_config.Set(keys::kProxyConfigRules, proxy_rules);
@@ -323,9 +323,9 @@ TEST(ExtensionProxyApiHelpers, GetProxyServer) {
TEST(ExtensionProxyApiHelpers, JoinUrlList) {
bool bad_message = false;
base::ListValue list;
- list.Append(Value::CreateStringValue("s1"));
- list.Append(Value::CreateStringValue("s2"));
- list.Append(Value::CreateStringValue("s3"));
+ list.Append(new base::StringValue("s1"));
+ list.Append(new base::StringValue("s2"));
+ list.Append(new base::StringValue("s3"));
std::string out;
std::string error;
@@ -355,7 +355,7 @@ TEST(ExtensionProxyApiHelpers, CreateProxyRulesDict) {
expected->Set("fallbackProxy",
CreateTestProxyServerDict("socks4", "proxy4", 80));
base::ListValue* bypass_list = new base::ListValue;
- bypass_list->Append(Value::CreateStringValue("localhost"));
+ bypass_list->Append(new base::StringValue("localhost"));
expected->Set(keys::kProxyConfigBypassList, bypass_list);
EXPECT_TRUE(Value::Equals(expected.get(), extension_pref.get()));
@@ -383,7 +383,7 @@ TEST(ExtensionProxyApiHelpers, CreateProxyRulesDictMultipleProxies) {
expected->Set("fallbackProxy",
CreateTestProxyServerDict("socks4", "proxy4", 80));
base::ListValue* bypass_list = new base::ListValue;
- bypass_list->Append(Value::CreateStringValue("localhost"));
+ bypass_list->Append(new base::StringValue("localhost"));
expected->Set(keys::kProxyConfigBypassList, bypass_list);
EXPECT_TRUE(Value::Equals(expected.get(), extension_pref.get()));
@@ -421,9 +421,9 @@ TEST(ExtensionProxyApiHelpers, CreatePacScriptDictWidthData) {
TEST(ExtensionProxyApiHelpers, TokenizeToStringList) {
base::ListValue expected;
- expected.Append(Value::CreateStringValue("s1"));
- expected.Append(Value::CreateStringValue("s2"));
- expected.Append(Value::CreateStringValue("s3"));
+ expected.Append(new base::StringValue("s1"));
+ expected.Append(new base::StringValue("s2"));
+ expected.Append(new base::StringValue("s3"));
scoped_ptr<base::ListValue> out(TokenizeToStringList("s1;s2;s3", ";"));
EXPECT_TRUE(Value::Equals(&expected, out.get()));
« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api_helpers.cc ('k') | chrome/browser/extensions/api/rtc_private/rtc_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698