chrome/browser/extensions/api/omnibox/omnibox_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

index 06db5b85dfebfd7347296c8f519b7d674057d5c6..18250ad0d280c70c4d639d4a526ca9865b53ffb5 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

@@ -127,8 +127,8 @@ bool ExtensionOmniboxEventRouter::OnInputChanged(

return false;

scoped_ptr<base::ListValue> args(new base::ListValue());

- args->Set(0, Value::CreateStringValue(input));

- args->Set(1, Value::CreateIntegerValue(suggest_id));

+ args->Set(0, new base::StringValue(input));

+ args->Set(1, new base::FundamentalValue(suggest_id));

scoped_ptr<Event> event(new Event(events::kOnInputChanged, args.Pass()));

event->restrict_to_profile = profile;

@@ -154,13 +154,13 @@ void ExtensionOmniboxEventRouter::OnInputEntered(

active_tab_permission_granter()->GrantIfRequested(extension);

scoped_ptr<base::ListValue> args(new base::ListValue());

- args->Set(0, Value::CreateStringValue(input));

+ args->Set(0, new base::StringValue(input));

if (disposition == NEW_FOREGROUND_TAB)

- args->Set(1, Value::CreateStringValue(kForegroundTabDisposition));

+ args->Set(1, new base::StringValue(kForegroundTabDisposition));

else if (disposition == NEW_BACKGROUND_TAB)

- args->Set(1, Value::CreateStringValue(kBackgroundTabDisposition));

+ args->Set(1, new base::StringValue(kBackgroundTabDisposition));

else

- args->Set(1, Value::CreateStringValue(kCurrentTabDisposition));

+ args->Set(1, new base::StringValue(kCurrentTabDisposition));

scoped_ptr<Event> event(new Event(events::kOnInputEntered, args.Pass()));

event->restrict_to_profile = profile;