chrome/browser/extensions/api/system_private/system_private_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_private/system_private_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc ('k') | chrome/browser/extensions/api/system_storage/system_storage_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_private/system_private_api.cc

diff --git a/chrome/browser/extensions/api/system_private/system_private_api.cc b/chrome/browser/extensions/api/system_private/system_private_api.cc

index 55296e3bc438b16bdb4f438927011694994c1da5..758f6b7a6e0b08e5a1ffdfb3e153d2634ec87088 100644

--- a/chrome/browser/extensions/api/system_private/system_private_api.cc

+++ b/chrome/browser/extensions/api/system_private/system_private_api.cc

@@ -67,7 +67,7 @@ bool SystemPrivateGetIncognitoModeAvailabilityFunction::RunImpl() {

EXTENSION_FUNCTION_VALIDATE(

value >= 0 &&

value < static_cast<int>(arraysize(kIncognitoModeAvailabilityStrings)));

- SetResult(Value::CreateStringValue(kIncognitoModeAvailabilityStrings[value]));

+ SetResult(new base::StringValue(kIncognitoModeAvailabilityStrings[value]));

return true;

}