chrome/browser/extensions/api/system_storage/system_storage_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/system_storage/system_storage_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/system_storage/system_storage_api.h"	5 #include "chrome/browser/extensions/api/system_storage/system_storage_api.h"

6	6

7 namespace extensions {	7 namespace extensions {

8	8

9 using api::system_storage::StorageUnitInfo;	9 using api::system_storage::StorageUnitInfo;

10 namespace EjectDevice = api::system_storage::EjectDevice;	10 namespace EjectDevice = api::system_storage::EjectDevice;

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 result = api::system_storage::EJECT_DEVICE_RESULT_CODE_IN_USE;	80 result = api::system_storage::EJECT_DEVICE_RESULT_CODE_IN_USE;

81 break;	81 break;

82 case chrome::StorageMonitor::EJECT_NO_SUCH_DEVICE:	82 case chrome::StorageMonitor::EJECT_NO_SUCH_DEVICE:

83 result = api::system_storage::	83 result = api::system_storage::

84 EJECT_DEVICE_RESULT_CODE_NO_SUCH_DEVICE;	84 EJECT_DEVICE_RESULT_CODE_NO_SUCH_DEVICE;

85 break;	85 break;

86 case chrome::StorageMonitor::EJECT_FAILURE:	86 case chrome::StorageMonitor::EJECT_FAILURE:

87 result = api::system_storage::EJECT_DEVICE_RESULT_CODE_FAILURE;	87 result = api::system_storage::EJECT_DEVICE_RESULT_CODE_FAILURE;

88 }	88 }

89	89

90 SetResult(base::StringValue::CreateStringValue(	90 SetResult(new base::StringValue(

91 api::system_storage::ToString(result)));	91 api::system_storage::ToString(result)));

92 SendResponse(true);	92 SendResponse(true);

93 }	93 }

94	94

95 } // namespace extensions	95 } // namespace extensions

OLD	NEW