Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types. (Closed)

Created:
7 years, 4 months ago by Ilya Sherman
Modified:
7 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, dbeam+watch-options_chromium.org, Raman Kakilate, jam, tfarina, benquan, haitaol+watch_chromium.org, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, rsimha+watch_chromium.org, rouslan+autofillwatch_chromium.org, Nicolas Zea, Jói
Visibility:
Public.

Description

[Autofill] Distinguish between native field types and potentially HTML field types. The Autofill code currently uses a single enum AutofillFieldType to describe all field types. However, several of the field type hints provided in the HTML autocomplete specification do not map nicely onto the native (server-supported) field types. This CL replaces all uses of the AutofillFieldType enum with either (1) a new enum, NativeFieldType, for code that does not need to be aware of HTML field types (2) AutofillType, a wrapper type that will be able to wrap either a native field type or an HTML type hint. TBR=estade@chromium.org BUG=254682, 261978 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216075

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : NativeFieldType -> ServerFieldType #

Patch Set 5 : Rebase #

Patch Set 6 : native_type -> server_type #

Patch Set 7 : Fix Windows compile #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+947 lines, -831 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/autofill/form_structure_browsertest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 2 3 4 5 6 7 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 6 7 18 chunks +42 lines, -37 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 4 5 12 chunks +44 lines, -30 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_view_delegate.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.h View 11 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 2 3 4 5 13 chunks +29 lines, -26 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper_unittest.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/mock_autofill_dialog_view_delegate.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.mm View 1 2 3 4 5 6 7 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/browser/autocheckout_manager.cc View 1 2 3 4 5 4 chunks +15 lines, -15 lines 0 comments Download
M components/autofill/content/browser/autocheckout_manager_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/form_field_error.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/content/browser/wallet/form_field_error.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/full_wallet.h View 2 chunks +4 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/full_wallet.cc View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/content/browser/wallet/full_wallet_unittest.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_items.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_items.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/address.h View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M components/autofill/core/browser/address.cc View 1 2 3 4 5 5 chunks +22 lines, -21 lines 0 comments Download
M components/autofill/core/browser/address_field.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address_field.cc View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M components/autofill/core/browser/address_field_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address_unittest.cc View 1 2 3 5 chunks +26 lines, -17 lines 0 comments Download
M components/autofill/core/browser/android/auxiliary_profiles_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_common_test.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_data_model.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_data_model.cc View 1 2 3 4 5 3 chunks +12 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_data_model_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_download.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_download.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_download_unittest.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_field.h View 1 2 3 3 chunks +12 lines, -10 lines 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 1 2 3 4 5 5 chunks +7 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc View 1 2 3 4 5 6 1 chunk +5 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 3 4 5 7 chunks +10 lines, -13 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 4 5 9 chunks +16 lines, -16 lines 0 comments Download
M components/autofill/core/browser/autofill_merge_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 2 3 9 chunks +14 lines, -14 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.h View 1 2 3 9 chunks +23 lines, -22 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 2 3 4 5 27 chunks +107 lines, -104 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 1 2 3 10 chunks +12 lines, -9 lines 0 comments Download
M components/autofill/core/browser/autofill_server_field_info.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_type.h View 1 2 3 4 5 1 chunk +12 lines, -9 lines 0 comments Download
M components/autofill/core/browser/autofill_type.cc View 1 2 3 4 5 7 chunks +15 lines, -18 lines 0 comments Download
M components/autofill/core/browser/autofill_type_unittest.cc View 1 2 3 4 5 1 chunk +10 lines, -10 lines 0 comments Download
M components/autofill/core/browser/autofill_xml_parser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/contact_info.h View 1 2 3 4 chunks +12 lines, -10 lines 0 comments Download
M components/autofill/core/browser/contact_info.cc View 1 2 3 6 chunks +10 lines, -12 lines 0 comments Download
M components/autofill/core/browser/credit_card.h View 1 2 3 3 chunks +10 lines, -9 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 2 3 4 5 9 chunks +32 lines, -29 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 11 chunks +23 lines, -11 lines 0 comments Download
M components/autofill/core/browser/email_field.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/email_field.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/field_types.h View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M components/autofill/core/browser/form_field.h View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/form_field.cc View 1 2 3 4 chunks +4 lines, -5 lines 0 comments Download
M components/autofill/core/browser/form_field_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_group.h View 1 2 3 4 5 3 chunks +11 lines, -9 lines 0 comments Download
M components/autofill/core/browser/form_group.cc View 1 2 3 4 5 1 chunk +15 lines, -16 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 2 3 4 5 17 chunks +36 lines, -31 lines 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 1 2 3 16 chunks +27 lines, -27 lines 0 comments Download
M components/autofill/core/browser/name_field.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/name_field.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/name_field_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 3 4 5 13 chunks +34 lines, -26 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_field.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_field.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_number.h View 1 2 3 4 chunks +11 lines, -10 lines 0 comments Download
M components/autofill/core/browser/phone_number.cc View 1 2 3 4 5 8 chunks +25 lines, -20 lines 0 comments Download
M components/autofill/core/browser/phone_number_unittest.cc View 1 2 3 7 chunks +30 lines, -25 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ilya Sherman
7 years, 4 months ago (2013-08-03 06:51:59 UTC) #1
Ilya Sherman
Apologies for the giant CL. It's pretty mechanical, though. Note that it's currently based on ...
7 years, 4 months ago (2013-08-03 07:05:18 UTC) #2
Ilya Sherman
Evan, PTAL at this guy, the mechanical support for [ https://chromiumcodereview.appspot.com/22009003/ ].
7 years, 4 months ago (2013-08-06 05:38:37 UTC) #3
Ilya Sherman
On 2013/08/06 05:38:37, Ilya Sherman (Away Aug. 9-25) wrote: > Evan, PTAL at this guy, ...
7 years, 4 months ago (2013-08-06 05:39:02 UTC) #4
Evan Stade
spot-checked a number of files, rslgtm
7 years, 4 months ago (2013-08-06 23:11:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/22009003/28001
7 years, 4 months ago (2013-08-07 00:34:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19187
7 years, 4 months ago (2013-08-07 00:53:11 UTC) #7
Ilya Sherman
TBR zea for //chrome/browser/sync and joi for //components/webdata
7 years, 4 months ago (2013-08-07 01:08:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/22009003/28001
7 years, 4 months ago (2013-08-07 01:17:08 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19247
7 years, 4 months ago (2013-08-07 03:05:20 UTC) #10
Ilya Sherman
Committed patchset #8 manually as r216075 (presubmit successful).
7 years, 4 months ago (2013-08-07 04:56:54 UTC) #11
Jói
7 years, 4 months ago (2013-08-12 10:40:24 UTC) #12
Message was sent while issue was closed.
//components/webdata LGTM

Powered by Google App Engine
This is Rietveld 408576698