components/autofill/core/browser/personal_data_manager.h - Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/name_field_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.h

diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h

index 36e578f7cc7c289ac1e1b7de50ad7bd681fe0735..b9ab979fdfde8646a3a9390036fa54ca7d893777 100644

--- a/components/autofill/core/browser/personal_data_manager.h

+++ b/components/autofill/core/browser/personal_data_manager.h

@@ -109,7 +109,7 @@ class PersonalDataManager : public WebDataServiceConsumer,

CreditCard* GetCreditCardByGUID(const std::string& guid);

// Gets the field types availabe in the stored address and credit card data.

- void GetNonEmptyTypes(FieldTypeSet* non_empty_types);

+ void GetNonEmptyTypes(ServerFieldTypeSet* non_empty_types);

// Returns true if the credit card information is stored with a password.

bool HasPassword();

@@ -130,10 +130,10 @@ class PersonalDataManager : public WebDataServiceConsumer,

// has already been autofilled. |other_field_types| represents the rest of

// form. Identifying info is loaded into the last four outparams.

void GetProfileSuggestions(

- AutofillFieldType type,

+ const AutofillType& type,

const base::string16& field_contents,

bool field_is_autofilled,

- std::vector<AutofillFieldType> other_field_types,

+ std::vector<ServerFieldType> other_field_types,

std::vector<base::string16>* values,

std::vector<base::string16>* labels,

std::vector<base::string16>* icons,

@@ -143,7 +143,7 @@ class PersonalDataManager : public WebDataServiceConsumer,

// GetProfileSuggestions for argument descriptions. The variant in each

// GUID pair should be ignored.

void GetCreditCardSuggestions(

- AutofillFieldType type,

+ const AutofillType& type,

const base::string16& field_contents,

std::vector<base::string16>* values,

std::vector<base::string16>* labels,