components/autofill/core/browser/autofill_manager.h - Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index c0fa3dbbdee75cb52b2f8201c6d27528973de9d9..b9e4d3115229f56c37ce035654e7eb904ed74c31 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -23,7 +23,6 @@

#include "components/autofill/core/browser/autocomplete_history_manager.h"

#include "components/autofill/core/browser/autofill_download.h"

#include "components/autofill/core/browser/autofill_manager_delegate.h"

-#include "components/autofill/core/browser/field_types.h"

#include "components/autofill/core/browser/form_structure.h"

#include "components/autofill/core/browser/personal_data_manager.h"

#include "components/autofill/core/common/autocheckout_status.h"

@@ -54,10 +53,11 @@ class AutofillDataModel;

class AutofillDownloadManager;

class AutofillExternalDelegate;

class AutofillField;

-class AutofillProfile;

class AutofillManagerDelegate;

class AutofillManagerTestDelegate;

class AutofillMetrics;

+class AutofillProfile;

+class AutofillType;

class CreditCard;

class FormStructureBrowserTest;

@@ -283,7 +283,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

// is filled with the Profile label.

void GetProfileSuggestions(FormStructure* form,

const FormFieldData& field,

- AutofillFieldType type,

+ const AutofillType& type,

std::vector<base::string16>* values,

std::vector<base::string16>* labels,

std::vector<base::string16>* icons,

@@ -292,7 +292,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

// Returns a list of values from the stored credit cards that match |type| and

// the value of |field| and returns the labels of the matching credit cards.

void GetCreditCardSuggestions(const FormFieldData& field,

- AutofillFieldType type,

+ const AutofillType& type,

std::vector<base::string16>* values,

std::vector<base::string16>* labels,

std::vector<base::string16>* icons,