chrome/browser/autofill/autofill_browsertest.cc - Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | chrome/browser/autofill/form_structure_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_browsertest.cc

diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc

index 995025ae5fc62c28a437f2fff6ad4cf3c8532e27..b1cda4b6e5e388e6ac6ac15392c92c9bea6c54f5 100644

--- a/chrome/browser/autofill/autofill_browsertest.cc

+++ b/chrome/browser/autofill/autofill_browsertest.cc

@@ -1009,7 +1009,8 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, FillProfileCrazyCharacters) {

L"\u898f\u7ba1\u5c0e\u904a"));

profile1.SetRawInfo(ADDRESS_HOME_ZIP, WideToUTF16(L"YOHO_54676"));

profile1.SetRawInfo(PHONE_HOME_WHOLE_NUMBER, WideToUTF16(L"861088828000"));

- profile1.SetInfo(ADDRESS_HOME_COUNTRY, WideToUTF16(L"India"), "en-US");

+ profile1.SetInfo(

+ AutofillType(ADDRESS_HOME_COUNTRY), WideToUTF16(L"India"), "en-US");

profiles.push_back(profile1);

AutofillProfile profile2;

@@ -1076,8 +1077,9 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, FillProfileCrazyCharacters) {

profile7.SetRawInfo(ADDRESS_HOME_STATE, WideToUTF16(L"CA"));

profile7.SetRawInfo(ADDRESS_HOME_ZIP, WideToUTF16(L"94086"));

profile7.SetRawInfo(PHONE_HOME_WHOLE_NUMBER, WideToUTF16(L"15466784565"));

- profile7.SetInfo(ADDRESS_HOME_COUNTRY, WideToUTF16(L"United States"),

- "en-US");

+ profile7.SetInfo(

+ AutofillType(ADDRESS_HOME_COUNTRY), WideToUTF16(L"United States"),

+ "en-US");

profiles.push_back(profile7);

SetProfiles(&profiles);

@@ -1148,8 +1150,9 @@ IN_PROC_BROWSER_TEST_F(AutofillTest, Invalid) {

without_invalid.SetRawInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Sunnyvale"));

without_invalid.SetRawInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("CA"));

without_invalid.SetRawInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("my_zip"));

- without_invalid.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("United States"),

- "en-US");

+ without_invalid.SetInfo(

+ AutofillType(ADDRESS_HOME_COUNTRY), ASCIIToUTF16("United States"),

+ "en-US");

AutofillProfile with_invalid = without_invalid;

with_invalid.SetRawInfo(PHONE_HOME_WHOLE_NUMBER,