components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc - Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

Issue 22009003: [Autofill] Distinguish between native field types and potentially HTML field types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_ie_toolbar_import_win.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

diff --git a/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc b/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

index dd343d1f7e7051f3fb6e3a7c7331f2a20b5c68c0..61917bcaf3778188e92d3ad3c42cc736fc4cbc95 100644

--- a/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

+++ b/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

@@ -170,9 +170,11 @@ TEST_F(AutofillIeToolbarImportTest, TestAutofillImport) {

EXPECT_EQ(profile1[3].value, profiles[1].GetRawInfo(EMAIL_ADDRESS));

EXPECT_EQ(profile1[4].value, profiles[1].GetRawInfo(COMPANY_NAME));

EXPECT_EQ(profile1[7].value,

- profiles[1].GetInfo(PHONE_HOME_COUNTRY_CODE, "US"));

- EXPECT_EQ(profile1[6].value, profiles[1].GetInfo(PHONE_HOME_CITY_CODE, "US"));

- EXPECT_EQ(L"5555555", profiles[1].GetInfo(PHONE_HOME_NUMBER, "US"));

+ profiles[1].GetInfo(AutofillType(PHONE_HOME_COUNTRY_CODE), "US"));

+ EXPECT_EQ(profile1[6].value,

+ profiles[1].GetInfo(AutofillType(PHONE_HOME_CITY_CODE), "US"));

+ EXPECT_EQ(L"5555555",

+ profiles[1].GetInfo(AutofillType(PHONE_HOME_NUMBER), "US"));

EXPECT_EQ(L"+1 650-555-5555",

profiles[1].GetRawInfo(PHONE_HOME_WHOLE_NUMBER));