[Autofill] Distinguish between native field types and potentially HTML field types.

components/autofill/core/browser/credit_card_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/guid.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_common_test.h"
+#include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/validation.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "grit/webkit_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace autofill {
 namespace {
 
 // From https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm
@@ skipping 301 matching lines @@
 
   card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("7"));
   EXPECT_EQ(ASCIIToUTF16("07"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
   EXPECT_EQ(7, card.expiration_month());
 
   // This should fail, and preserve the previous value.
   card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("January"));
   EXPECT_EQ(ASCIIToUTF16("07"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
   EXPECT_EQ(7, card.expiration_month());
 
-  card.SetInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("January"), "en-US");
+  card.SetInfo(
+      AutofillType(CREDIT_CARD_EXP_MONTH), ASCIIToUTF16("January"), "en-US");
   EXPECT_EQ(ASCIIToUTF16("01"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
   EXPECT_EQ(1, card.expiration_month());
 
-  card.SetInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("Apr"), "en-US");
+  card.SetInfo(
+      AutofillType(CREDIT_CARD_EXP_MONTH), ASCIIToUTF16("Apr"), "en-US");
   EXPECT_EQ(ASCIIToUTF16("04"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
   EXPECT_EQ(4, card.expiration_month());
 }
 
 TEST(CreditCardTest, CreditCardType) {
   CreditCard card(base::GenerateGUID(), "https://www.example.com/");
 
   // The card type cannot be set directly.
   card.SetRawInfo(CREDIT_CARD_TYPE, ASCIIToUTF16("Visa"));
   EXPECT_EQ(base::string16(), card.GetRawInfo(CREDIT_CARD_TYPE));
@@ skipping 21 matching lines @@
     options[i] = ASCIIToUTF16(kMonthsNumeric[i]);
   }
 
   FormFieldData field;
   field.form_control_type = "select-one";
   field.option_values = options;
   field.option_contents = options;
 
   CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
   credit_card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("01"));
-  credit_card.FillSelectControl(CREDIT_CARD_EXP_MONTH, "en-US", &field);
+  credit_card.FillSelectControl(
+      AutofillType(CREDIT_CARD_EXP_MONTH), "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("01"), field.value);
 }
 
 TEST(CreditCardTest, CreditCardMonthAbbreviated) {
   const char* const kMonthsAbbreviated[] = {
     "Jan", "Feb", "Mar", "Apr", "May", "Jun",
     "Jul", "Aug", "Sep", "Oct", "Nov", "Dec",
   };
   std::vector<base::string16> options(arraysize(kMonthsAbbreviated));
   for (size_t i = 0; i < arraysize(kMonthsAbbreviated); ++i) {
     options[i] = ASCIIToUTF16(kMonthsAbbreviated[i]);
   }
 
   FormFieldData field;
   field.form_control_type = "select-one";
   field.option_values = options;
   field.option_contents = options;
 
   CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
   credit_card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("01"));
-  credit_card.FillSelectControl(CREDIT_CARD_EXP_MONTH, "en-US", &field);
+  credit_card.FillSelectControl(
+      AutofillType(CREDIT_CARD_EXP_MONTH), "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("Jan"), field.value);
 }
 
 TEST(CreditCardTest, CreditCardMonthFull) {
   const char* const kMonthsFull[] = {
     "January", "February", "March", "April", "May", "June",
     "July", "August", "September", "October", "November", "December",
   };
   std::vector<base::string16> options(arraysize(kMonthsFull));
   for (size_t i = 0; i < arraysize(kMonthsFull); ++i) {
     options[i] = ASCIIToUTF16(kMonthsFull[i]);
   }
 
   FormFieldData field;
   field.form_control_type = "select-one";
   field.option_values = options;
   field.option_contents = options;
 
   CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
   credit_card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("01"));
-  credit_card.FillSelectControl(CREDIT_CARD_EXP_MONTH, "en-US", &field);
+  credit_card.FillSelectControl(
+      AutofillType(CREDIT_CARD_EXP_MONTH), "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("January"), field.value);
 }
 
 TEST(CreditCardTest, CreditCardMonthNumeric) {
   const char* const kMonthsNumeric[] = {
     "1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12",
   };
   std::vector<base::string16> options(arraysize(kMonthsNumeric));
   for (size_t i = 0; i < arraysize(kMonthsNumeric); ++i) {
     options[i] = ASCIIToUTF16(kMonthsNumeric[i]);
   }
 
   FormFieldData field;
   field.form_control_type = "select-one";
   field.option_values = options;
   field.option_contents = options;
 
   CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
   credit_card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("01"));
-  credit_card.FillSelectControl(CREDIT_CARD_EXP_MONTH, "en-US", &field);
+  credit_card.FillSelectControl(
+      AutofillType(CREDIT_CARD_EXP_MONTH), "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("1"), field.value);
 }
 
 TEST(CreditCardTest, CreditCardTwoDigitYear) {
   const char* const kYears[] = {
     "12", "13", "14", "15", "16", "17", "18", "19"
   };
   std::vector<base::string16> options(arraysize(kYears));
   for (size_t i = 0; i < arraysize(kYears); ++i) {
     options[i] = ASCIIToUTF16(kYears[i]);
   }
 
   FormFieldData field;
   field.form_control_type = "select-one";
   field.option_values = options;
   field.option_contents = options;
 
   CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
   credit_card.SetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR, ASCIIToUTF16("2017"));
-  credit_card.FillSelectControl(CREDIT_CARD_EXP_4_DIGIT_YEAR, "en-US", &field);
+  credit_card.FillSelectControl(
+      AutofillType(CREDIT_CARD_EXP_4_DIGIT_YEAR), "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("17"), field.value);
   EXPECT_EQ(2017, credit_card.expiration_year());
 }
 
 TEST(CreditCardTest, CreditCardTypeSelectControl) {
   const char* const kCreditCardTypes[] = {
     "Visa", "Master Card", "AmEx", "discover"
   };
   std::vector<base::string16> options(arraysize(kCreditCardTypes));
   for (size_t i = 0; i < arraysize(kCreditCardTypes); ++i) {
     options[i] = ASCIIToUTF16(kCreditCardTypes[i]);
   }
 
   FormFieldData field;
   field.form_control_type = "select-one";
   field.option_values = options;
   field.option_contents = options;
 
   // Credit card types are inferred from the numbers, so we use test numbers for
   // each card type. Test card numbers are drawn from
   // http://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm
 
   {
     // Normal case:
     CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
     credit_card.SetRawInfo(CREDIT_CARD_NUMBER,
                            ASCIIToUTF16("4111111111111111"));
-    credit_card.FillSelectControl(CREDIT_CARD_TYPE, "en-US", &field);
+    credit_card.FillSelectControl(
+        AutofillType(CREDIT_CARD_TYPE), "en-US", &field);
     EXPECT_EQ(ASCIIToUTF16("Visa"), field.value);
   }
 
   {
     // Filling should be able to handle intervening whitespace:
     CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
     credit_card.SetRawInfo(CREDIT_CARD_NUMBER,
                            ASCIIToUTF16("5105105105105100"));
-    credit_card.FillSelectControl(CREDIT_CARD_TYPE, "en-US", &field);
+    credit_card.FillSelectControl(
+        AutofillType(CREDIT_CARD_TYPE), "en-US", &field);
     EXPECT_EQ(ASCIIToUTF16("Master Card"), field.value);
   }
 
   {
     // American Express is sometimes abbreviated as AmEx:
     CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
     credit_card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16("371449635398431"));
-    credit_card.FillSelectControl(CREDIT_CARD_TYPE, "en-US", &field);
+    credit_card.FillSelectControl(
+        AutofillType(CREDIT_CARD_TYPE), "en-US", &field);
     EXPECT_EQ(ASCIIToUTF16("AmEx"), field.value);
   }
 
   {
     // Case insensitivity:
     CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
     credit_card.SetRawInfo(CREDIT_CARD_NUMBER,
                            ASCIIToUTF16("6011111111111117"));
-    credit_card.FillSelectControl(CREDIT_CARD_TYPE, "en-US", &field);
+    credit_card.FillSelectControl(
+        AutofillType(CREDIT_CARD_TYPE), "en-US", &field);
     EXPECT_EQ(ASCIIToUTF16("discover"), field.value);
   }
 }
 
 TEST(CreditCardTest, GetCreditCardType) {
   struct {
     std::string card_number;
     std::string type;
     bool is_valid;
   } test_cases[] = {
@@ skipping 149 matching lines @@
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     base::string16 card_number = ASCIIToUTF16(test_cases[i].card_number);
     SCOPED_TRACE(card_number);
     EXPECT_EQ(test_cases[i].type, CreditCard::GetCreditCardType(card_number));
     EXPECT_EQ(test_cases[i].is_valid, IsValidCreditCardNumber(card_number));
   }
 }
 
 }  // namespace autofill